cpp: Do not add resource file in static builds #259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The resource file
FastCdr.rc
seems to be unnecessary in static builds and break cross-compilation with mingw unnecessarily.This patch uses CMake's generator expressions to only include them when building shared libraries.
I have build tested it with
-DBUILD_SHARED_LIBS=0
and=1
with a native Linux gcc 12.2.0 on Debian and a mingw-gcc (built with (MXE)[https://github.com/mxe/mxe]), respectively.Fixes #166
Contributor Checklist
versions.md
file (if applicable).Aint nobody got time for admin shenanigans. I don't deem the single line copyrighted/copyrightable.
Reviewer Checklist