Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp: Do not add resource file in static builds #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefanct
Copy link

Description

The resource file FastCdr.rc seems to be unnecessary in static builds and break cross-compilation with mingw unnecessarily.
This patch uses CMake's generator expressions to only include them when building shared libraries.
I have build tested it with -DBUILD_SHARED_LIBS=0 and =1 with a native Linux gcc 12.2.0 on Debian and a mingw-gcc (built with (MXE)[https://github.com/mxe/mxe]), respectively.

Fixes #166

Contributor Checklist

  • [❌] Commit messages follow the project guidelines.
  • [❌] The code follows the style guidelines of this project.
  • [❌] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [❌] Any new/modified methods have been properly documented using Doxygen.
  • [❌] Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • [❌] Changes are API compatible.
  • [❌] New feature has been added to the versions.md file (if applicable).
  • [❌] Applicable backports have been included in the description.

Aint nobody got time for admin shenanigans. I don't deem the single line copyrighted/copyrightable.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

Signed-off-by: Stefan Tauner <stefan.tauner@artech.at>
@stefanct stefanct marked this pull request as ready for review December 18, 2024 18:39
stefanct added a commit to stefanct/PlotJuggler that referenced this pull request Jan 3, 2025
This patch is equivalent to the one submitted upstream as
eProsima/Fast-CDR#259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant