Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21286] Run CodeQL on macOS-13 instead of 11 (backport #220) #222

Merged
merged 2 commits into from
Jul 12, 2024
Merged

[21286] Run CodeQL on macOS-13 instead of 11 (backport #220) #222

merged 2 commits into from
Jul 12, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 12, 2024

Description

macOS-11 runner images are discontinued, so CodeQL jobs are failing cause they cannot pick a mac runner. This PR changes the runner image to macOS-13, which is still active.

@Mergifyio backport 2.2.x 2.1.x 1.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.
This is an automatic backport of pull request #220 done by [Mergify](https://mergify.com).

@EduPonz @mergify
Run CodeQL on macOS-13 instead of 11 (#220)
fc10b81 
* Refs #21286: Run CodeQL on macOS-13 instead of 11

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #21286: Remove 1.1.x from the backport list, as it is attached to 2.6.x

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #21286: Use CodeQL action v3

Signed-off-by: eduponz <eduardoponz@eprosima.com>

---------

Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit 624080a)
@mergify mergify bot mentioned this pull request Jul 12, 2024
Merged
7 tasks
@JesusPoderoso JesusPoderoso added this to the v1.0.29 milestone Jul 12, 2024
@JesusPoderoso JesusPoderoso self-requested a review July 12, 2024 07:03
JesusPoderoso
JesusPoderoso approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany
Copy link
Member

The affected workflow only triggers for master branch, so this backport is not necessary.

We might consider adding the supported branches to the workflow in the master branch.

@JesusPoderoso
Refs #21286: Apply Miguel' suggestion
5d7fabd 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@MiguelCompany MiguelCompany merged commit bd1c6a6 into 1.0.x Jul 12, 2024
7 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/1.0.x/pr-220 branch July 12, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
v1.0.29
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @JesusPoderoso @EduPonz