Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnection tests [12522] #45

Merged
merged 11 commits into from
Nov 22, 2021
Merged

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Oct 6, 2021

Reverts #44.

This PR restore the changes made in #41.
Do not merge until eProsima/Fast-DDS#2247 is merged.

@rsanchez15 rsanchez15 force-pushed the revert-44-revert-41-test/reconnect_tests branch from b133eef to 2e3b557 Compare October 6, 2021 05:32
@rsanchez15
Copy link
Contributor Author

This PR is approved in favor of #41.

@rsanchez15 rsanchez15 closed this Oct 26, 2021
@rsanchez15 rsanchez15 reopened this Oct 26, 2021
@jparisu jparisu force-pushed the revert-44-revert-41-test/reconnect_tests branch 2 times, most recently from a9f490a to 65298f7 Compare October 26, 2021 12:55
rsanchez15 and others added 3 commits October 29, 2021 08:38
Signed-off-by: RaulSanchez <raul@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu force-pushed the revert-44-revert-41-test/reconnect_tests branch from 242f4b7 to 7da8203 Compare October 29, 2021 06:39
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu added 3 commits November 3, 2021 09:53
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@MiguelCompany MiguelCompany requested a review from jsan-rt November 4, 2021 11:39
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial Review pending xml and snapshot check

src/main.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
Signed-off-by: jparisu <javierparis@eprosima.com>
Copy link
Contributor

@jsan-rt jsan-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jparisu added 2 commits November 16, 2021 09:37
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…test 50

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit 798f165 into master Nov 22, 2021
@MiguelCompany MiguelCompany deleted the revert-44-revert-41-test/reconnect_tests branch November 22, 2021 11:34
cferreiragonz pushed a commit that referenced this pull request Apr 17, 2024
* Revert "Revert "Reconnection tests [12522]""

Signed-off-by: RaulSanchez <raul@eprosima.com>

* Refs #12522: Add test for tool reconnection

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Add client reconnect test

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Uncomment SHM_ON

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Set test 41 time longer for jenkins

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Set test 42 time longer for jenkins

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Set test 43 time longer for jenkins

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Apply suggestions

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Change 39 name number to 60

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Extend 39 test time

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Delayed third snapshot and all steps after that one for test 50

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

Co-authored-by: jparisu <javierparis@eprosima.com>
Co-authored-by: Javier Santiago <javiersantiago@eprosima.com>
cferreiragonz pushed a commit that referenced this pull request Apr 29, 2024
* Revert "Revert "Reconnection tests [12522]""

Signed-off-by: RaulSanchez <raul@eprosima.com>

* Refs #12522: Add test for tool reconnection

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Add client reconnect test

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Uncomment SHM_ON

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Set test 41 time longer for jenkins

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Set test 42 time longer for jenkins

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Set test 43 time longer for jenkins

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Apply suggestions

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Change 39 name number to 60

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Extend 39 test time

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Delayed third snapshot and all steps after that one for test 50

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

Co-authored-by: jparisu <javierparis@eprosima.com>
Co-authored-by: Javier Santiago <javiersantiago@eprosima.com>
cferreiragonz pushed a commit that referenced this pull request Apr 29, 2024
* Revert "Revert "Reconnection tests [12522]""

Signed-off-by: RaulSanchez <raul@eprosima.com>

* Refs #12522: Add test for tool reconnection

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Add client reconnect test

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Uncomment SHM_ON

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Set test 41 time longer for jenkins

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Set test 42 time longer for jenkins

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Set test 43 time longer for jenkins

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Apply suggestions

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Change 39 name number to 60

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Extend 39 test time

Signed-off-by: jparisu <javierparis@eprosima.com>

* Refs #12522: Delayed third snapshot and all steps after that one for test 50

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

Co-authored-by: jparisu <javierparis@eprosima.com>
Co-authored-by: Javier Santiago <javiersantiago@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants