Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app_id and app_metadata attributes #72

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Conversation

jepemi
Copy link
Contributor

@jepemi jepemi commented Nov 3, 2023

Add app_id and app_metadata to discovery properties.

@jepemi jepemi changed the title app_id and app_metadata attributes Add app_id and app_metadata attributes Nov 6, 2023
Copy link
Contributor

@irenebm irenebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncrustify

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@jepemi jepemi force-pushed the feature/app_id_metadata branch from 850e3e2 to 26eb0c3 Compare November 16, 2023 09:53
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
Copy link
Contributor

@irenebm irenebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irenebm irenebm merged commit 621ad13 into main Nov 16, 2023
12 checks passed
@irenebm irenebm deleted the feature/app_id_metadata branch November 16, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants