Remove change before creation in full writer's history (#122)

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>

ddspipe_participants/src/cpp/writer/rtps/CommonWriter.cpp

@@ -156,6 +156,13 @@ utils::ReturnCode CommonWriter::write_nts_(
 {
     auto& rtps_data = dynamic_cast<RtpsPayloadData&>(data);
 
+    if (rtps_history_->isFull())
+    {
+        // Remove the oldest cache change when the max history size is reached.
+        // NOTE: This should be done as a first step, otherwise the creation of a new change would fail.
+        rtps_history_->remove_min_change();
+    }
+
     // Take new Change from history
     fastrtps::rtps::CacheChange_t* new_change;
 
@@ -191,12 +198,6 @@ utils::ReturnCode CommonWriter::write_nts_(
         return ret;
     }
 
-    if (rtps_history_->isFull())
-    {
-        // Remove the oldest cache change when the max history size is reached.
-        rtps_history_->remove_min_change();
-    }
-
     // Send data by adding it to CommonWriter History
     rtps_history_->add_change(new_change, write_params);