fix restartability bug for upper layer

[JacksonYao287]

if it is not first-time-boot, the uuid of HO is saved in metaservice. so we need to get the uuid after metaservice is started, otherwise we will get a new default uuid

[xiaoxichen]

This suggests we are wrong in https://github.com/eBay/HomeStore/pull/284/files
for restart, the _our_id in HO is set by homestore_metablk_callback, which will be called after meta svc started in https://github.com/eBay/HomeStore/blob/master/src/lib/homestore.cpp#L210

In the #284 we move the initialization of GenericReplService from start to do_start.

I think we either
a. move https://github.com/eBay/HomeStore/blob/master/src/lib/homestore.cpp#L198 down below L210
or
b. move L198 back to start() , remove wrong comments and take the change in this PR to get uuid in GenericReplService::start() in L217

[xiaoxichen]

check back with #284

[JacksonYao287]

@xiaoxichen
for a, we can not make this change, since the register_handler happens in the constructor of RaftReplService

HomeStore/src/lib/replication/service/raft_repl_service.cpp

Line 64 in 67cca17

meta_service().register_handler(

if we put L198 down below L210, then the handler can not be registered before metaservice#start, which will lead to a missing raft config.

well, b is acceptable, will do this!

fixed

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 47.70%. Comparing base (2f5f94d) to head (4d5bebf).

Files	Patch %	Lines
src/lib/homestore.cpp	0.00%	1 Missing ⚠️
src/lib/replication/service/generic_repl_svc.cpp	0.00%	1 Missing ⚠️
src/lib/replication/service/raft_repl_service.cpp	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   47.70%   47.70%           
=======================================
  Files         107      107           
  Lines        9305     9307    +2     
  Branches     1209     1209           
=======================================
+ Hits         4439     4440    +1     
+ Misses       4393     4392    -1     
- Partials      473      475    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xiaoxichen]

lgtm

Though we had seen an initialized uuid default value for m_repl_app->get_my_repl_id() and do not know the reason, but maybe
RELEASE_ASSERT(!m_my_uuid.value().is_nil(), "Uninitialized RaftReplService UUID");

[JacksonYao287]

lgtm

Though we had seen an initialized uuid default value for m_repl_app->get_my_repl_id() and do not know the reason, but maybe RELEASE_ASSERT(!m_my_uuid.value().is_nil(), "Uninitialized RaftReplService UUID");

ok, will add it in the later coming PR