Fix shutdown sequence with cp mgr. #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkadayam
reviewed
Jan 9, 2024
hkadayam
reviewed
Jan 9, 2024
a513a08 to
373a079
Compare
yamingk
reviewed
Jan 9, 2024
4d10150 to
5ced47b
Compare
yamingk
previously approved these changes
Jan 10, 2024
32981f0 to
5ecde2e
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
===========================================
- Coverage 68.21% 48.64% -19.58%
===========================================
Files 96 111 +15
Lines 8016 8764 +748
Branches 1041 1126 +85
===========================================
- Hits 5468 4263 -1205
- Misses 2033 4157 +2124
+ Partials 515 344 -171 ☔ View full report in Codecov by Sentry. |
10f173c to
a3cb512
Compare
Add blocking cp flush in cp mgr shutdown. Added atomic to stop cp to trigger another cp. Destroy in btree and index dont need cp context. As cp mgr already shutdown, shut the cp mgr first. Test meta blk used directly calling meta service api's to simulate recovery, instead use homestore restart to simulate a recovery.
a3cb512 to
f4df532
Compare
hkadayam
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add blocking cp flush in cp mgr shutdown. Added atomic to stop cp to trigger another cp.
Destroy in btree and index dont need cp context. As cp mgr already shutdown.
Shut the cp mgr first.
Test meta blk used directly calling meta service api's to simulate recovery, instead use homestore restart to simulate a recovery.