Skip to content

Commit

Permalink
set old wbreq to null in the completion callback to reduce the ref co…
Browse files Browse the repository at this point in the history
…unter
  • Loading branch information
Ravi Nagarjun Akella authored and Ravi Nagarjun Akella committed Feb 6, 2025
1 parent d551720 commit ebf7565
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

class HomestoreConan(ConanFile):
name = "homestore"
version = "3.8.1"
version = "3.8.2"

homepage = "https://github.corp.ebay.com/SDS/homestore"
description = "HomeStore"
Expand Down
5 changes: 5 additions & 0 deletions src/engine/homeds/btree/writeBack_cache.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,11 @@ class WriteBackCache : public std::enable_shared_from_this< WriteBackCache< K, V
queue_flush_buffers(nullptr);
}
ResourceMgrSI().dec_dirty_buf_cnt(m_node_size);

// we are done with this wb_req
HS_REL_ASSERT_EQ(wb_req, wb_req->bn->req[cp_id]);
wb_req->bn->req[cp_id] = nullptr;

/* req and btree node are pointing to each other which is preventing neither of them to be freed */
wb_req->bn = nullptr;

Expand Down

0 comments on commit ebf7565

Please sign in to comment.