Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix php 8.4 deprecations #17

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix php 8.4 deprecations #17

merged 1 commit into from
Dec 3, 2024

Conversation

ptmkenny
Copy link
Contributor

@ptmkenny ptmkenny commented Dec 3, 2024

PHP 8.4 warns that passing an implicit null is deprecated.

Fixed with:

  $rectorConfig->rule(\Rector\Php84\Rector\Param\ExplicitNullableParamTypeRector::class);

e0ipso
e0ipso approved these changes Dec 3, 2024
View reviewed changes
Copy link
Owner

@e0ipso e0ipso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good!

@e0ipso e0ipso merged commit 78e5142 into e0ipso:master Dec 3, 2024
@e0ipso
Copy link
Owner

e0ipso commented Dec 3, 2024

Merged and released.

@ptmkenny
Copy link
Contributor Author

ptmkenny commented Dec 3, 2024

Many thanks!

@e0ipso
Copy link
Owner

e0ipso commented Dec 3, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e0ipso e0ipso e0ipso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptmkenny @e0ipso