Create a dataframe version of has_final_labels #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try two separate versions of applying `has_final_labels` for dataframes. - one row by row using `dataframe.apply` - the other filtering directly with column-wise operations I think that the second is more peformant so going with it for now If that is no longer true, we can switch back to the `apply`, in which case we can remove `has_final_labels_df`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try two separate versions of applying
has_final_labelsfor dataframes.dataframe.applyI think that the second is more peformant so going with it for now
If that is no longer true, we can switch back to the
apply, in which case wecan remove
has_final_labels_df