Performance improvement for the diary loading #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankari
added a commit
to shankari/e-mission-phone
that referenced
this pull request
Aug 1, 2020
…s well + handled this similar to the server code with multiple promises in parallel e-mission#703 + handle stupid bug leading to "invalid date". We were populating the day using "day", but in moment, that is the day of the week. We need to use "date" instead. Since dates in moment are 1 indexed, this manifests as a invalid date if tested on Sunday Bonus of working on the weekend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance for diary loading by making all remote calls in parallel. This is a restricted port of #609 which removes the survey answers that are currently not used on master. The surveyanswers are removed in 202624c The others are original commits from @atton16 that he did not submit to master.