Use specific prettier version #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Homebrew installs packages differently depending on chip architecture -- updated the setup script to reflect this difference.
📟 🛠️ Update `setup_ios_native.sh` to support Apple Silicone
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## service_rewrite_2023 #1117 +/- ##
=====================================================
Coverage 58.80% 58.80%
=====================================================
Files 26 26
Lines 1420 1420
Branches 320 320
=====================================================
Hits 835 835
Misses 585 585
Flags with carried forward coverage won't be shown. Click here to find out more. |
JGreenlee
approved these changes
Dec 13, 2023
| @@ -7,5 +7,6 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - run: npx prettier --check www | |||
| - run: npx prettier@3.0.3 --check www | |||
There was a problem hiding this comment.
Good to know we can set it to use a specific version this way!
JGreenlee
added a commit
to JGreenlee/e-mission-phone
that referenced
this pull request
Dec 14, 2023
In 4f173ba I bumped the prettier version to 3.1. Whatever version we are using for the project should be the same as the workflow runs with (as we established in e-mission#1117)
JGreenlee
added a commit
to JGreenlee/e-mission-phone
that referenced
this pull request
Jan 25, 2024
In 4f173ba I bumped the prettier version to 3.1. Whatever version we are using for the project should be the same as the workflow runs with (as we established in e-mission#1117)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Prettierfailed on the UI Migration Wrap-up PR, and we discovered that it uses the latest Prettier version on GitHub Actions but version 3.0.3 in the project. Therefore, we have decided to stick with the specific version (3.0.3) to prevent this issue from occurring again.