Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed button(s) #1105

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fixed button(s) #1105

merged 2 commits into from
Nov 22, 2023

Conversation

niccolopaganini
Copy link
Contributor

  • Wide buttons in the demographics page
  • Issue for reference: 1015

@niccolopaganini
Copy link
Contributor Author

Prettier failed, running through prettier...

@niccolopaganini
Copy link
Contributor Author

Seems like all the tests are passing...

@shankari
Copy link
Contributor

@niccolopaganini please indicate testing done before submitting for review.

@JGreenlee
Copy link
Collaborator

@niccolopaganini For a small UI bugfix like this, screenshots (like before vs. after) would be sufficient for demonstrating "testing done". We just need to see that it was fixed.

@niccolopaganini
Copy link
Contributor Author

For the before refer Issue 1015

Here's the picture of the after:

@shankari shankari merged commit 26638a7 into e-mission:service_rewrite_2023 Nov 22, 2023
2 checks passed
@shankari shankari mentioned this pull request Feb 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JGreenlee JGreenlee JGreenlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niccolopaganini @shankari @JGreenlee