-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major refactor of 2D filament finding #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d test for the function
… added to an intersection
…s separate branches
…ncluded in an intersection, keeping the intersection 8-connected across the T, and causing issues with the total path length
…eleton analysis. Move operations into dedicated Filament2D classes
…rune branch properties consistently
…ead of recomputing everything
This was referenced Mar 29, 2018
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining the current code base is a huge pain. This PR is intended to make the code easier to work with by providing a new 2D filament finding class:
FilFinder2D
.Also new is the
Filament2D
class. Instead of looping through operations on the filaments in an image,FilFinder2D
defines a set ofFilament2D
objects, where the property finding routines are now located. This removes the need to drag along a set of arrays for each skeleton, as well as their offset positions, whichfil_finder_2D
is not handling correctly. #39 will be fixed by removing the need to add any padding. It also allows for operating on individual filaments for greater control of the analysis.An on-going list of updates:
2(sqrt(2) - 1)
so highly unlikely to cause a large issue).find_filpix
, where skeletons are split into pixel groups, was revamped to correctly account for this shapeglob_thresh
redefined to be a data value, not a percentile of the data (easier to set based on the noise level)fil_finder_2D
so a warning is added to avoid using the widths from this method.FilFinder2D
andFilament2D
return astropy tables instead of offering functions to save tables. This is easier than trying to account for all of the different file formats.To-do:
FilFinder2D
fil_finder_2D