feat(ui): url step for steps component EBS-1316 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceisipeik
reviewed
Apr 3, 2024
libs/ui/src/lib/circle/circle.ts
Outdated
| @@ -1,10 +1,11 @@ | |||
| export type CircleTheme = 'dark' | 'light'; | |||
| export type CircleTheme = 'dark' | 'light' | 'dark-filled'; | |||
There was a problem hiding this comment.
Just a thought, that instead of new theme 'dark-filled', this can also be achieved with
- theme = 'light'
- severity = 'info'
- and adding a style attribute to the
cvi-ng-circlecomponent with the custom border colour (same as 'info' background)style="--cvi-circle-border-color: --cvi-color-sea-green-10"
There was a problem hiding this comment.
Good idea! Implemented!
ceisipeik
reviewed
Apr 3, 2024
libs/ui/src/lib/circle/circle.ts
Outdated
| @@ -29,13 +30,23 @@ export const circleThemePropertyGroups: CircleThemePropertyGroup[] = [ | |||
| properties: { | |||
| '--border-color': '--cvi-color-sapphire-blue-13', | |||
| '--color': '--cvi-color-sapphire-blue-13', | |||
| '--background-color': 'transparent', | |||
There was a problem hiding this comment.
Just in case check if adding custom border colour with themes 'dark' and 'light' still work, now that the --background-color is defined here.
certainlyakey
requested changes
Apr 3, 2024
certainlyakey
requested changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.