GH-2177 Extend prometheus with new metrics #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update prometheus metrics to latest version - Expose additional jetty metrics - Expose additional queued thread pool metrics - Expose additional reposilite metrics
…sponse time Removes request uri from response time, as > The generally accepted rough limit for a single Prometheus server is in the low millions of time series > https://discuss.prometheus.io/t/windows-network-traffic-by-remote-ip/1626 The prometheus docs recommend keeping the cardinality of metrics low (generally under like 100-ish): https://prometheus.io/docs/practices/instrumentation/#do-not-overuse-labels
dzikoysk
requested changes
Jul 27, 2024
There was a problem hiding this comment.
Looks good! Added some minor comments + I think it'd be nice to add at least one test to check if it even starts 😅 Here's tiny example how to bootstrap it for a plugin: https://github.com/dzikoysk/reposilite/blob/main/reposilite-plugins/migration-plugin/src/test/kotlin/com/reposilite/plugin/migration/MigrationPluginTest.kt#L12
...ugins/prometheus-plugin/src/main/kotlin/com/reposilite/plugin/prometheus/PrometheusPlugin.kt
Outdated
Show resolved
Hide resolved
...ugins/prometheus-plugin/src/main/kotlin/com/reposilite/plugin/prometheus/PrometheusPlugin.kt
Outdated
Show resolved
Hide resolved
...ugins/prometheus-plugin/src/main/kotlin/com/reposilite/plugin/prometheus/PrometheusPlugin.kt
Outdated
Show resolved
Hide resolved
...s-plugin/src/main/kotlin/com/reposilite/plugin/prometheus/metrics/QueuedThreadPoolMetrics.kt
Outdated
Show resolved
Hide resolved
|
This looks great, thank you! |
|
@dzikoysk I've applied all suggested changes, it's ready to merge now |
dzikoysk
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the prometheus metrics plugin.
Changes: