-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Super /Mega Linter #1
Changes from 22 commits
8cfff98
182aa29
59f25af
e32a1b1
02ca4ac
8b80603
97f0d3c
9e1acb2
1a2f1b9
2b5a2aa
f45055a
5740033
1c44ac3
e275a84
e405099
502d2b9
a703659
7818031
e7bee80
44e0667
54c84f9
593a20f
4a2d876
604f94f
265842c
1c5c78c
2b7061e
b534acf
3239bbe
b66f400
cfce6f6
96529fe
9a1d28e
04b7d8d
eb57892
2773558
a5989fe
1fe2957
9d873f5
d86dd57
e6ae701
9183a4c
570d002
9bd1558
653ba86
2f2ee60
45c7284
aedae88
d36dfdb
5033865
1246eee
9b5f461
87fde33
836dafa
e8abc7f
e3d8e0e
259dad2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
--- | ||
name: Linting | ||
|
||
on: # yamllint disable-line rule:truthy | ||
# push: null | ||
pull_request: null | ||
|
||
permissions: {} | ||
|
||
jobs: | ||
Super_Linter: | ||
name: Super Linter | ||
runs-on: ubuntu-latest | ||
|
||
permissions: | ||
contents: read | ||
packages: read | ||
# To report GitHub Actions status checks | ||
statuses: write | ||
|
||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
with: | ||
# super-linter needs the full git history to get the | ||
# list of files that changed across commits | ||
fetch-depth: 0 | ||
|
||
- name: Super-linter | ||
uses: super-linter/super-linter@v7.2.0 # x-release-please-version | ||
env: | ||
# Linters | ||
VALIDATE_MARKDOWN: true | ||
# VALIDATE_RUST_CLIPPY: true # Cant Use as the version is not at 1.81 yet in the linter | ||
VALIDATE_YAML: true | ||
# Auto Fix the files | ||
# FIX_RUST_CLIPPY: true # Cant Use as the version is not at 1.81 yet in the linter | ||
FIX_MARKDOWN: true | ||
ENABLE_GITHUB_ACTIONS_STEP_SUMMARY: true | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
# Remove this section when Super Linter is updated (https://github.com/dysonltd/tmag5273/issues/3) | ||
Clippy: | ||
name: Clippy | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With a little jiggery-pokery it's possible to run clippy on doc examples too Info can be found here - the bits you need are kind of dotted about but if you think it's worth implementing I've got a working example I was using on one of our other repos There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this would be good to add. Especially since the Super Linter isnt upgraded yet for the latest rust version (#3). Are you able to share here and il add it in? |
||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
- name: Clippy check on src | ||
run: cargo clippy --manifest-path Cargo.toml -- -D warnings | ||
- name: Clippy check on utils | ||
run: cargo clippy --manifest-path utils/Cargo.toml -- -D warnings | ||
- name: Clippy check on esp32 example | ||
run: | | ||
cd examples/esp32-c3 | ||
cargo clippy --manifest-path ./Cargo.toml -- -D warnings | ||
# Had to run in the esp32c3 directory to get rid of <https://github.com/taiki-e/portable-atomic/issues/148> | ||
|
||
Formatter: | ||
name: Cargo Formatter | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
- name: Rustfmt check on src | ||
run: cargo fmt --manifest-path Cargo.toml -- --check | ||
- name: Rustfmt check on utils | ||
run: cargo fmt --manifest-path utils/Cargo.toml -- --check | ||
- name: Rustfmt check on esp32 example | ||
run: cargo fmt --manifest-path examples/esp32-c3/Cargo.toml -- --check |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
# Compiled files | ||
/target/ | ||
utils/target/ | ||
|
||
# Dependency directories | ||
Cargo.lock | ||
|
This file was deleted.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it possible to inherit a lint standard for markdown instead of having a long file of custom configuration like this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So you can run markdownlint with the standard and we would need to apply two settings around line length. This is how it was originally and was in json, but then SuperLinter needed a yaml file as it wasnt reading the json for some reason.... We should be able to solve this by moving to MegaLinter |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,277 @@ | ||
# Example markdownlint configuration with all properties set to their default value | ||
|
||
# Default state for all rules | ||
default: true | ||
|
||
# Path to configuration file to extend | ||
extends: null | ||
|
||
# MD001/heading-increment : Heading levels should only increment by one level at a time : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md001.md | ||
MD001: true | ||
|
||
# MD003/heading-style : Heading style : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md003.md | ||
MD003: | ||
# Heading style | ||
style: "consistent" | ||
|
||
# MD004/ul-style : Unordered list style : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md004.md | ||
MD004: | ||
# List style | ||
style: "consistent" | ||
|
||
# MD005/list-indent : Inconsistent indentation for list items at the same level : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md005.md | ||
MD005: true | ||
|
||
# MD007/ul-indent : Unordered list indentation : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md007.md | ||
MD007: | ||
# Spaces for indent | ||
indent: 2 | ||
# Whether to indent the first level of the list | ||
start_indented: false | ||
# Spaces for first level indent (when start_indented is set) | ||
start_indent: 2 | ||
|
||
# MD009/no-trailing-spaces : Trailing spaces : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md009.md | ||
MD009: | ||
# Spaces for line break | ||
br_spaces: 2 | ||
# Allow spaces for empty lines in list items | ||
list_item_empty_lines: false | ||
# Include unnecessary breaks | ||
strict: false | ||
|
||
# MD010/no-hard-tabs : Hard tabs : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md010.md | ||
MD010: | ||
# Include code blocks | ||
code_blocks: true | ||
# Fenced code languages to ignore | ||
ignore_code_languages: [] | ||
# Number of spaces for each hard tab | ||
spaces_per_tab: 1 | ||
|
||
# MD011/no-reversed-links : Reversed link syntax : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md011.md | ||
MD011: true | ||
|
||
# MD012/no-multiple-blanks : Multiple consecutive blank lines : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md012.md | ||
MD012: | ||
# Consecutive blank lines | ||
maximum: 1 | ||
|
||
# MD013/line-length : Line length : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md013.md | ||
MD013: | ||
# Number of characters | ||
line_length: 80 | ||
# Number of characters for headings | ||
heading_line_length: 80 | ||
# Number of characters for code blocks | ||
code_block_line_length: 200 | ||
# Include code blocks | ||
code_blocks: true | ||
# Include tables | ||
tables: true | ||
# Include headings | ||
headings: true | ||
# Strict length checking | ||
strict: false | ||
# Stern length checking | ||
stern: false | ||
|
||
# MD014/commands-show-output : Dollar signs used before commands without showing output : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md014.md | ||
MD014: true | ||
|
||
# MD018/no-missing-space-atx : No space after hash on atx style heading : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md018.md | ||
MD018: true | ||
|
||
# MD019/no-multiple-space-atx : Multiple spaces after hash on atx style heading : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md019.md | ||
MD019: true | ||
|
||
# MD020/no-missing-space-closed-atx : No space inside hashes on closed atx style heading : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md020.md | ||
MD020: true | ||
|
||
# MD021/no-multiple-space-closed-atx : Multiple spaces inside hashes on closed atx style heading : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md021.md | ||
MD021: true | ||
|
||
# MD022/blanks-around-headings : Headings should be surrounded by blank lines : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md022.md | ||
MD022: | ||
# Blank lines above heading | ||
lines_above: 1 | ||
# Blank lines below heading | ||
lines_below: 1 | ||
|
||
# MD023/heading-start-left : Headings must start at the beginning of the line : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md023.md | ||
MD023: true | ||
|
||
# MD024/no-duplicate-heading : Multiple headings with the same content : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md024.md | ||
MD024: | ||
# Only check sibling headings | ||
siblings_only: false | ||
|
||
# MD025/single-title/single-h1 : Multiple top-level headings in the same document : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md025.md | ||
MD025: | ||
# Heading level | ||
level: 1 | ||
# RegExp for matching title in front matter | ||
front_matter_title: "^\\s*title\\s*[:=]" | ||
|
||
# MD026/no-trailing-punctuation : Trailing punctuation in heading : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md026.md | ||
MD026: | ||
# Punctuation characters | ||
punctuation: ".,;:!。,;:!" | ||
|
||
# MD027/no-multiple-space-blockquote : Multiple spaces after blockquote symbol : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md027.md | ||
MD027: true | ||
|
||
# MD028/no-blanks-blockquote : Blank line inside blockquote : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md028.md | ||
MD028: true | ||
|
||
# MD029/ol-prefix : Ordered list item prefix : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md029.md | ||
MD029: | ||
# List style | ||
style: "one_or_ordered" | ||
|
||
# MD030/list-marker-space : Spaces after list markers : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md030.md | ||
MD030: | ||
# Spaces for single-line unordered list items | ||
ul_single: 1 | ||
# Spaces for single-line ordered list items | ||
ol_single: 1 | ||
# Spaces for multi-line unordered list items | ||
ul_multi: 1 | ||
# Spaces for multi-line ordered list items | ||
ol_multi: 1 | ||
|
||
# MD031/blanks-around-fences : Fenced code blocks should be surrounded by blank lines : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md031.md | ||
MD031: | ||
# Include list items | ||
list_items: true | ||
|
||
# MD032/blanks-around-lists : Lists should be surrounded by blank lines : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md032.md | ||
MD032: true | ||
|
||
# MD033/no-inline-html : Inline HTML : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md033.md | ||
MD033: | ||
# Allowed elements | ||
allowed_elements: [] | ||
|
||
# MD034/no-bare-urls : Bare URL used : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md034.md | ||
MD034: true | ||
|
||
# MD035/hr-style : Horizontal rule style : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md035.md | ||
MD035: | ||
# Horizontal rule style | ||
style: "consistent" | ||
|
||
# MD036/no-emphasis-as-heading : Emphasis used instead of a heading : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md036.md | ||
MD036: | ||
# Punctuation characters | ||
punctuation: ".,;:!?。,;:!?" | ||
|
||
# MD037/no-space-in-emphasis : Spaces inside emphasis markers : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md037.md | ||
MD037: true | ||
|
||
# MD038/no-space-in-code : Spaces inside code span elements : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md038.md | ||
MD038: true | ||
|
||
# MD039/no-space-in-links : Spaces inside link text : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md039.md | ||
MD039: true | ||
|
||
# MD040/fenced-code-language : Fenced code blocks should have a language specified : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md040.md | ||
MD040: | ||
# List of languages | ||
allowed_languages: [] | ||
# Require language only | ||
language_only: false | ||
|
||
# MD041/first-line-heading/first-line-h1 : First line in a file should be a top-level heading : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md041.md | ||
MD041: | ||
# Heading level | ||
level: 1 | ||
# RegExp for matching title in front matter | ||
front_matter_title: "^\\s*title\\s*[:=]" | ||
|
||
# MD042/no-empty-links : No empty links : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md042.md | ||
MD042: true | ||
|
||
# MD043/required-headings : Required heading structure : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md043.md | ||
MD043: | ||
# List of headings | ||
headings: [ "*" ] | ||
# Match case of headings | ||
match_case: false | ||
|
||
# MD044/proper-names : Proper names should have the correct capitalization : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md044.md | ||
MD044: | ||
# List of proper names | ||
names: [] | ||
# Include code blocks | ||
code_blocks: true | ||
# Include HTML elements | ||
html_elements: true | ||
|
||
# MD045/no-alt-text : Images should have alternate text (alt text) : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md045.md | ||
MD045: true | ||
|
||
# MD046/code-block-style : Code block style : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md046.md | ||
MD046: | ||
# Block style | ||
style: "consistent" | ||
|
||
# MD047/single-trailing-newline : Files should end with a single newline character : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md047.md | ||
MD047: true | ||
|
||
# MD048/code-fence-style : Code fence style : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md048.md | ||
MD048: | ||
# Code fence style | ||
style: "consistent" | ||
|
||
# MD049/emphasis-style : Emphasis style : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md049.md | ||
MD049: | ||
# Emphasis style | ||
style: "consistent" | ||
|
||
# MD050/strong-style : Strong style : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md050.md | ||
MD050: | ||
# Strong style | ||
style: "consistent" | ||
|
||
# MD051/link-fragments : Link fragments should be valid : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md051.md | ||
MD051: | ||
# Ignore case of fragments | ||
ignore_case: false | ||
|
||
# MD052/reference-links-images : Reference links and images should use a label that is defined : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md052.md | ||
MD052: | ||
# Include shortcut syntax | ||
shortcut_syntax: false | ||
|
||
# MD053/link-image-reference-definitions : Link and image reference definitions should be needed : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md053.md | ||
MD053: | ||
# Ignored definitions | ||
ignored_definitions: | ||
- "//" | ||
|
||
# MD054/link-image-style : Link and image style : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md054.md | ||
MD054: | ||
# Allow autolinks | ||
autolink: true | ||
# Allow inline links and images | ||
inline: true | ||
# Allow full reference links and images | ||
full: true | ||
# Allow collapsed reference links and images | ||
collapsed: true | ||
# Allow shortcut reference links and images | ||
shortcut: true | ||
# Allow URLs as inline links | ||
url_inline: true | ||
|
||
# MD055/table-pipe-style : Table pipe style : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md055.md | ||
MD055: | ||
# Table pipe style | ||
style: "consistent" | ||
|
||
# MD056/table-column-count : Table column count : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md056.md | ||
MD056: true | ||
|
||
# MD058/blanks-around-tables : Tables should be surrounded by blank lines : https://github.com/DavidAnson/markdownlint/blob/v0.36.1/doc/md058.md | ||
MD058: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this line required still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will be moving away from this actually after finding MegaLinter
https://megalinter.io/v8/
It handles the analysis slightly differently.