Remove http.app_root. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In-reply-to: open-telemetry#263 (comment)
Oberon00
added a commit
that referenced
this pull request
Oct 29, 2019
* Update HTTP conventions. * Improve HTTP, fix references to peer.*. * Wording. * typo a/an http * host.name/host.port * Clarify server_name. * Typo, missing 'has'. * Typo nginx link. * Wording. * Typo in span name convention. Co-Authored-By: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com> * Wording for common HTTP intro. In response to @SergeyKanzhelev (open-telemetry#263 (comment)). * Make http.flavor non-required. In-reply-to: open-telemetry#263 (comment) Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com> * Clarify client's http.url. In-reply-to: open-telemetry#263 (comment) * HTTP server span name: reference `http.app_root`. In-reply-to: open-telemetry#263 (comment) * Split "Definitions" from conventions, clarify app_root. In-reply-to: open-telemetry#263 (comment) * Qualify order of http server attr preferences. In-reply-to: open-telemetry#263 (comment) * Address review comments. * Typo. * Make http.status_code conditionally required. * Move http.host,target,scheme; clarify empty host. * Fix misplaced paragraph. * Fix client host/port requirement. * Fix HTTP status code OC incompat annotations. * Fix incomplete sentence. * Markdown syntax. * Update HTTP example (remove URL, add client). In-reply-to: open-telemetry#263 (comment) * Fix markdownlint. * Typo. * Remove http.app Span attribute. In-reply-to: open-telemetry#263 (comment) In-reply-to: open-telemetry#263 (comment) * Fix lint. ./specification/data-semantic-conventions.md:155: MD036 Emphasis used instead of a header * Add note about n:1 server_name + app_root => app. * Typo. * Remove http.app_root. (#4) In-reply-to: open-telemetry#263 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-reply-to: open-telemetry#263 (comment)
@SergeyKanzhelev