fix: jsModule is null for basemap layer #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimPurdum
approved these changes
Jun 18, 2024
|
@CyberDNS thanks again for this, will update and merge! |
|
@CyberDNS whoops, forgot, this is coming from your repo, so you'll have to update to merge. Let me know if you need any help. |
|
@CyberDNS since I'm unable to update your repo to resolve conflicts, and I'm sure you are all as busy as we are, I'm going to close this PR and re-open with the same changes. |
TimPurdum
added a commit
that referenced
this pull request
Jul 20, 2024
TimPurdum
added a commit
that referenced
this pull request
Jul 20, 2024
…from_a_basemap_layer recreate from external PR #337
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi dear GeoBlazor Team,
Description:
We noticed an issue while setting visibility from a BaseMapLayer.
This issue can be reproduced only if a BaseMapLayer has been added by code to the MapView.
This issue does not occur if a BaseMapLayer has been added using markup of the component (Razor language).
Changes:
To fix this issue, JsModule has been set while executing the AddLayer method, whether isBasemapLayer is true or false.
New test method TestCanSetBaseMapLayerVisibility has been added to validate the fix.
Impact:
This change fix the failure while setting layer visibility from a BaseMapLayer.
Resolves #335
Br,
David from Team GIS - POST Luxembourg