Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh action testing #330

Merged
merged 20 commits into from
May 4, 2024
Merged

Gh action testing #330

merged 20 commits into from
May 4, 2024

Conversation

TimPurdum
Copy link
Collaborator

  • Fix for build that was failing to include JS files in nuget packages.
  • NOTE: I built this branch off of Demo/vs live #329, the only file that needs to be reviewed separately here is main-release-build.yml

{
_tokensAndControllers.Remove(cancellationToken);
Console.WriteLine(ex);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this is an initial iteration to add a try/catch. do we want to add a message specific to these two abort tasks?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors during object disposal usually have to do with race conditions of the object(s) already being disposed or set to null. In this case, I actually fixed the error I saw by switching to TryRemove, but I figured, even if we get an unknown error, we probably don't want to crash/throw. So in those cases, where I don't really expect anything, I tend to default to Console.WriteLine. I'm open to other suggestions, but if these are rare, a more detailed console message might not make a lot of difference, since it would be often ignored/missed.

/// </summary>
[Parameter]
[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
public string? ApiKey { get; set; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to move this to the layer class? Then it can be inherited by other layer types as they are added in the future or only insert this for specific layers as needed, like this case

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's based on the inheritance pattern in ArcGIS. ApiKey is only available on some Layers.

Copy link
Collaborator

@seahro seahro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple questions

@TimPurdum TimPurdum merged commit 088adac into develop May 4, 2024
2 checks passed
@TimPurdum TimPurdum deleted the gh-action-testing branch May 4, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants