fix for MapFont serialization #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seahro
reviewed
Apr 12, 2024
| @@ -38,7 +37,7 @@ public MapFont() | |||
| /// <param name="weight"> | |||
| /// The text weight. | |||
| /// </param> | |||
| public MapFont(int? size, string? family, string? style, string? weight) | |||
| public MapFont(Dimension? size, string? family, string? style, string? weight) | |||
There was a problem hiding this comment.
Dimension or double? for size... looking at the other size references below
There was a problem hiding this comment.
Dimension for the C# class. We serialize this in Protobuf as a double. Notice at the bottom of the file you are looking at MapFontSerializationRecord (protobuf representation).
seahro
approved these changes
Apr 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #320
MapFont serialization in Protobuf threw an exception because
Dimensionwas not defined in the serialization.Created a new
MapFontSerializationRecordthat converted Dimension to double, which matches what we do with other serializations using Dimension.