Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed package reference, rebuilt and tested #271

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

TimPurdum
Copy link
Collaborator

Closes #270

Copy link
Collaborator

@seahro seahro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and the arc version was updated.

"protobufjs-cli": "1.1.2"
"@arcgis/core": "4.28.10",
"esbuild": "0.19.8",
"protobufjs": "7.2.5"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we are just removing the cli? esbuild and arcgis are the updates.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protobufjs-cli, yes.

@TimPurdum TimPurdum merged commit 30d5dea into develop Dec 6, 2023
@TimPurdum TimPurdum deleted the feature/270-remove-protobufjs-cli branch December 6, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up unused and warning-causing NPM reference
2 participants