Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding/updating javascript file versioning #269

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

AndersenBell
Copy link
Collaborator

closes #268

Adds a query parameter that is the current GeoBlazor version to the requests for the js interop file to prevent browser caching after an update.

Also combined duplicate interop request code to a single source.

Copy link
Collaborator

@seahro seahro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question

Copy link
Collaborator

@seahro seahro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@seahro seahro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

Copy link
Collaborator

@TimPurdum TimPurdum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for consolidating the calls as well.

@AndersenBell AndersenBell self-assigned this Dec 4, 2023
@AndersenBell AndersenBell changed the title adding/updating versioning adding/updating javascript file versioning Dec 4, 2023
@AndersenBell AndersenBell merged commit e0a1234 into develop Dec 4, 2023
@AndersenBell AndersenBell deleted the feature/268-javascript-versioning branch December 4, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version JavaScript files to avoid caching issues
3 participants