fix pro wasm bug, refactor JS module loading #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seahro
reviewed
Nov 15, 2023
| { | ||
| if (ProJsViewModule is not null) | ||
| { | ||
| AddGraphicsProSyncInterop(graphics, id, layerId); |
There was a problem hiding this comment.
I assume the pro code PR will have this method adjustment, since the AddGraphicsCoreSyncInterop is the only method in Core's arcGISJsInterop.ts?
There was a problem hiding this comment.
Yes, the method didn't actually exist at all in arcGisPro.ts yet, it is added in that PR.
seahro
approved these changes
Nov 15, 2023
This was actually switching from a static method to an instance method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsModuleManagerstatic classPro.getCoremethod. I did this by loading the pro in theJSHost, and then having a duplicated implementation on the JS side of the synchronous method.