Widget and Feature Enhancements #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/dymaptic.GeoBlazor.Core/Scripts/jsBuilder.ts
| @@ -352,6 +380,11 @@ public async Task<FeatureEditsResult> ApplyEdits(FeatureEdits edits, FeatureEdit | |||
| return await JsLayerReference!.InvokeAsync<Domain?>("getFieldDomain", fieldName, feature); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
this needs a comment
| { | ||
| try | ||
| { |
There was a problem hiding this comment.
if there is not a pro module, will the try block throw an exception every time?
There was a problem hiding this comment.
It will, however, this method is only reached if you are trying to nest an otherwise invalid component, as the inherited override implementations correctly register all known child components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Widgets
Widgetsanywhere in Razor markup, using a newMapViewreference parameter.ExpandWidgetnow supports custom HTML child content in Razor markup, and can combine a child widget and custom HTMLLayers
FeatureLayerpropertiesApiKeyblendModelegendEnabledpopupEnabledFeatureLayer.GetCapabilitiesVisualVariablesforColorandOpacityMapView
AddWidgetandRemoveWidgetas public methods.Pro Support
MapView.AddLayerandLayer.Loadfor Pro JS moduleProPropertiesinMapComponentSignificant new unit tests surrounding changes