Implemented all properties on TextSymbol, unit tests and Label sample #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seahro
approved these changes
Oct 2, 2023
seahro
reviewed
Oct 2, 2023
| /// </remarks> | ||
| [Parameter] | ||
| [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] | ||
| public string? XOffset { get; set; } |
There was a problem hiding this comment.
In looking at the TextSymbol docs, I noticed that a number of these new properties are autocast, are not supported in 3d Sceneviews or are only applicable when TextSymbol is not used for labeling, is this why they are not added in the main TextSymbol constructor?
There was a problem hiding this comment.
No, they aren't added to the constructor because I forgot to update the constructor 🙂
seahro
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #231
XOffsetandYOffsetSymbolsTeststo verify that symbol is generated and all properties are setLabelssample that shows off some TextSymbol features