Bug/149 equality checks #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersenBell
approved these changes
Aug 9, 2023
| [JsonConverter(typeof(CSVDelimiterConverter))] | ||
| public enum CSVDelimiter | ||
| { | ||
| Comma, |
There was a problem hiding this comment.
Does this need the compiler warning turned off?
There was a problem hiding this comment.
yup, good catch! I started a release build after I pushed to make sure, and sure enough, the error is sitting waiting for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149
I was able to remove all equality checks from Geometries and related classes. These do not appear to be necessary anymore to prevent multiple registrations of graphics.
Also, while testing, I noticed that the CSV layer was not supporting the
PopupTemplate, which I thought was important for seeing the CSV data, so I added that, and updated the sample with a bit more "pizazz".