Feature/70 add wcslayer #204

seahro · 2023-07-24T18:03:37Z

Closes #70
Adds WCS Layer class and demo page
Subitems required to be created
-Creates the Raster Stretch Renderer class and methods
-DimensionalDefinitions class and methods for imagerylayers with mosaics

…wcs layer

… working on colorizing

…ng up razor display with designated colors

…s with method creates no error but fails silently and does not rendering after interop and definition refactor

…ill off

AndersenBell · 2023-07-28T15:16:57Z

src/dymaptic.GeoBlazor.Core/Scripts/arcGisJsInterop.ts

+            });
+            let wcsLayer = newLayer as WCSLayer;
+            newLayer = wcsLayer;
+            copyValuesIfExists(layerObject, wcsLayer, 'bandIds', 'copyright', 'coverageId', 'coverageInfo', 'customParameters', 'fields', 'interpolation', 'maxScale', 'minscale', 'multidimensionalDefinition', 'rasterInfo', 'renderer');


You may need to use the jsBuilder here rather then the copy values for the render and mulidimensionDefinition

… render greyscale. still working on the color values

TimPurdum

Roscoe, excellent work getting this all functioning! I'm giving you a lot of tidying feedback, and I would encourage you to review your own code more thoroughly (using a diff between develop and your own branch such as the tool in Rider, or using github.dev on the PR before requesting review), to catch more of these up front.

Also have a bit more work to support MapComponent inheritance for ColorRamp.

TimPurdum · 2023-08-02T20:34:58Z

src/dymaptic.GeoBlazor.Core/Components/Layers/WCSLayer.cs

+    ///     The url for the WCS Layer source data.
+    /// </param>
+
+    public WCSLayer(string? url = null, PortalItem? portalItem = null)


Add List<DimensionalDefinition> multidimensionalDefinition, RasterStretchRenderer renderer, double opacity, string title to this constructor. Use the constructor in your WCSLayers.razor samples page instead of setting these properties directly. In fact, I think we should make these private set; properties (only for the ones that are not also [Parameter]), because if you set them after the layer is rendered, it will break.

TimPurdum · 2023-08-02T20:35:46Z

src/dymaptic.GeoBlazor.Core/Components/Layers/WCSLayer.cs

+    public WCSLayer()
+    {
+    }
+    /// <summary>


there should be a space before these comments, and not one after them, for consistency.

Corrected across all the class files.

TimPurdum · 2023-08-02T20:36:25Z

samples/dymaptic.GeoBlazor.Core.Sample.Shared/Pages/WCSLayers.razor

+    <a class="btn btn-primary" target="_blank" href="something">NOAA Sea Surface Temperature Charts</a>
+</div>
+<Label>Add the sample WCS Layer URL to see a visualization of global sea surface temperature data with or without color rendering using the RasterStretch:</Label>
+<InputText @bind-Value="_wcsLayerUrl"></InputText>


I don't know that we really need this input field. I doubt anyone is going to test their own layers in our samples page.

removed. I think for some samples it makes sense to have the input field, others really dont need it.

TimPurdum · 2023-08-02T20:37:14Z

samples/dymaptic.GeoBlazor.Core.Sample.Shared/Pages/WCSLayers.razor

+    private bool _visible = false;
+    private bool _mapRendered = false;
+
+    private string _wcsLayerUrl2 = "https://sampleserver6.arcgisonline.com/arcgis/services/ScientificData/SeaTemperature/ImageServer/WCSServer";


This variable is never used and can be deleted.

an oversight while I was cleaning up the file...corrected.

TimPurdum · 2023-08-02T20:37:32Z

samples/dymaptic.GeoBlazor.Core.Sample.Shared/Pages/WCSLayers.razor

+    private MultipartColorRamp? multipartColorRamp;
+    private MapView _view;
+    private bool _markup = false;
+    private bool _visible = false;


TimPurdum · 2023-08-02T20:53:30Z

src/dymaptic.GeoBlazor.Core/Components/Renderers/Renderer.cs

@@ -72,6 +73,7 @@ public enum RendererType
 {
 #pragma warning disable CS1591
    Simple,
-    UniqueValue
+    UniqueValue,
+    RasterStretch


I think this should be removed and not used, since we discovered there is no inheritance. You could replace with just a string entry.

TimPurdum · 2023-08-02T20:54:30Z

src/dymaptic.GeoBlazor.Core/Scripts/arcGisJsInterop.ts

+                    wcsLayer.multidimensionalDefinition.push(wcsMDD);
+                }
+            }
+            copyValuesIfExists(layerObject, 'bandIds', 'copyright', 'coverageId', 'coverageInfo', 'customParameters', 'fields', 'interpolation', 'maxScale', 'minscale', 'rasterInfo');


looking through these, I wonder if fields is the same type as used in other places. We do have a buildJsField method.

it could be. These were not essential to the building the sample page and following the pattern from other classes, these were included based on the properties in the rasterstretchrenderer

TimPurdum · 2023-08-02T20:56:10Z

src/dymaptic.GeoBlazor.Core/Scripts/dotNetBuilder.ts

@@ -656,4 +667,56 @@ export function buildDotNetTimeExtent(timeExtent: any): any | null {
        start: timeExtent.start.toISOString(),
        end: timeExtent.end.toISOString()
    } as any;
+}
+
+export function buildDotNetDimensionDefinition(dimensionDefinition: DimensionalDefinition): any | null {


I don't think any of these methods are actually used. The use case for a dot net builder would be if the data was loaded from a server via JS, and then needed converting back to .NET. If there's no calling code, I would delete these (sorry).

removed these and the imports at the top of the file.

TimPurdum · 2023-08-02T20:56:49Z

src/dymaptic.GeoBlazor.Core/Scripts/jsBuilder.ts

+    return multidimensionalDefinition;
+}
+
+export function buildJSMultipartColorRamp(dotNetMultipartColorRamp: any): MultipartColorRamp | null {


lowercase s in Js

corrected in all spots

TimPurdum · 2023-08-02T20:57:24Z

src/dymaptic.GeoBlazor.Core/dymaptic.GeoBlazor.Core.csproj

@@ -22,6 +22,7 @@
        <GeneratePackageOnBuild Condition="$(Configuration) == 'RELEASE'">true</GeneratePackageOnBuild>
        <TargetFrameworks>net7.0;net6.0</TargetFrameworks>
        <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+        <UserSecretsId>364f0380-f3fa-441e-8138-e888b38a26c4</UserSecretsId>


user secrets definitely don't work in a library project

…definition to the wcs layer sample

TimPurdum

Just need some extra [Parameter]s marked and remove some extraneous constructors!

TimPurdum · 2023-08-03T21:27:14Z

src/dymaptic.GeoBlazor.Core/Components/Renderers/ColorRamps/ColorRamp.cs

+{
+    public ColorRamp() { }
+
+    public ColorRamp(ColorRampType colorRampType, MultipartColorRamp colorRamps)


abstract classes don't need constructors at all, unless you're going to call : base() from the inheriting class and pass values.

corrected and removed. noted for future classes

TimPurdum · 2023-08-03T21:28:15Z

src/dymaptic.GeoBlazor.Core/Components/Renderers/DimensionalDefinition.cs

+    ///     The dimension associated with the variable..
+    /// </summary>
+    [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
+    public string? DimensionName { get; set; }


These properties should be [Parameter] in this class

TimPurdum · 2023-08-03T21:28:50Z

src/dymaptic.GeoBlazor.Core/Components/Renderers/RasterStretchRenderer.cs

+    /// <summary>
+    ///     The computeGamma automatically calculates best gamma value to render exported image based on empirical model. This is applicable to any stretch type when useGamma is true.
+    /// </summary>
+    public bool? ComputeGamma { get; private set; }


Everything not set via RegisterChildComponent should be a [Parameter]

corrected, once the constructor was refactored, these should have been corrected.

TimPurdum · 2023-08-03T21:29:12Z

samples/dymaptic.GeoBlazor.Core.Sample.Shared/_Imports.razor

+@using System.Text.Json
+@using dymaptic.GeoBlazor.Core.Components.Renderers.ColorRamps


It would be nice to put this in alphabetically.

seahro · 2023-08-07T17:41:27Z

Adjusted the wcs sample page and classes to adjust to the new publish build effects of "warnings as errors". tested and operational

seahro added 10 commits July 18, 2023 08:37

initial razor page build

8d35418

build out interop file

dbbc0c2

working on class

2b0522c

Merge branch 'develop' into feature/70_add_wcslayer

dfa1c77

razor pg working

5a47c3f

working

db3c255

update branch

3312ec2

working

4766c02

Merge branch 'develop' into feature/70_add_wcslayer

aac38d7

raster stretch renderer added, multi dimensionaldefinition next

a2956e7

seahro self-assigned this Jul 24, 2023

seahro added 14 commits July 24, 2023 12:56

dimensiondefinition class in place working on methods

54525e2

dimensiondefinition added to builder and definitions

4648a5a

add color ramp class working on definitions

87fddb5

working

d3e154c

rasterstretch converter in place and child component registration in …

1eba18c

…wcs layer

working on razor display

2812782

initial render working color blend only black n white currently still…

b252340

… working on colorizing

multicolorramp and algorithmic color ramps in place working on wrappi…

4a617db

…ng up razor display with designated colors

dimensionaldefinition and renderer added to razor sample page

e57049f

layer properties set up for rendering on razor page

8b7df91

adjusting rgb list to map color property in js/ts

23bf08d

refactoring color objects

34bba50

build without errors, markup kick back raster exception error. add wc…

496554c

…s with method creates no error but fails silently and does not rendering after interop and definition refactor

razor page working no color works correctly color loads but colors st…

d7779bc

…ill off

AndersenBell reviewed Jul 28, 2023

View reviewed changes

seahro added 4 commits July 31, 2023 14:04

interop refactor working

0090d1a

working

3826a2e

working wcs in jsinterop

27120e6

major adjustments to jsbuilder, interop, and the classes. both layers…

2ada0a3

… render greyscale. still working on the color values

seahro added 2 commits August 2, 2023 09:58

refactor rasterstretchrenderer out of renderer

30241bf

color ramps rendering correctly and cleanup complete

44e6d7f

seahro requested review from TimPurdum and AndersenBell August 2, 2023 19:19

seahro marked this pull request as ready for review August 2, 2023 19:19

remove commented out code items

2e00b1b

TimPurdum requested changes Aug 2, 2023

View reviewed changes

seahro added 4 commits August 2, 2023 15:34

working on corrections

08f4674

corrected layer.cs to add wcs layer and added additional dimensional …

2024863

…definition to the wcs layer sample

refactors complete and rendering correctly

8c8e89a

corrections complete

15ebcbf

TimPurdum approved these changes Aug 3, 2023

View reviewed changes

seahro and others added 6 commits August 7, 2023 07:41

pr review 2 refactors and succesfully tested

160b292

merge from develop

118a10f

starting corrections for warnings

03dd90e

working on corrections

9391fa3

warnings as errors "issues" corrected

23be778

realigned branch with remote

a197586

Tested, cleanup

4825b16

TimPurdum merged commit d1c451f into develop Aug 7, 2023

TimPurdum deleted the feature/70_add_wcslayer branch August 7, 2023 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/70 add wcslayer #204

Feature/70 add wcslayer #204

seahro commented Jul 24, 2023

AndersenBell Jul 28, 2023

TimPurdum left a comment

TimPurdum Aug 2, 2023

TimPurdum Aug 2, 2023

seahro Aug 2, 2023

TimPurdum Aug 2, 2023

seahro Aug 2, 2023

TimPurdum Aug 2, 2023

seahro Aug 2, 2023

TimPurdum Aug 2, 2023

seahro Aug 2, 2023

TimPurdum Aug 2, 2023

TimPurdum Aug 2, 2023

seahro Aug 3, 2023

TimPurdum Aug 2, 2023

seahro Aug 7, 2023

TimPurdum Aug 2, 2023

seahro Aug 7, 2023

TimPurdum Aug 2, 2023

seahro Aug 7, 2023

TimPurdum left a comment

TimPurdum Aug 3, 2023

seahro Aug 7, 2023

TimPurdum Aug 3, 2023

seahro Aug 7, 2023

TimPurdum Aug 3, 2023

seahro Aug 7, 2023

TimPurdum Aug 3, 2023

seahro Aug 7, 2023

seahro commented Aug 7, 2023

		@using System.Text.Json
		@using dymaptic.GeoBlazor.Core.Components.Renderers.ColorRamps

Feature/70 add wcslayer #204

Feature/70 add wcslayer #204

Conversation

seahro commented Jul 24, 2023

Choose a reason for hiding this comment

TimPurdum left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimPurdum left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seahro commented Aug 7, 2023