Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra fixes for Pro widgets #198

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Extra fixes for Pro widgets #198

merged 1 commit into from
Jul 18, 2023

Conversation

TimPurdum
Copy link
Collaborator

A few extra things from the Pro work

  • Added Icon and WidgetId (aka JS Id) to Widget
  • Fixed the reason that the arcgis assets were not updating for me in Core.csproj
  • Added a debug catch around view.popup.on not being a thing when using the sketch tool (needs further investigation later).

@TimPurdum TimPurdum requested review from seahro and AndersenBell July 14, 2023 21:42
@TimPurdum TimPurdum self-assigned this Jul 14, 2023
seahro
seahro approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@seahro seahro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have seen this popup.on error only a couple of times (it seem infrequent).

@TimPurdum TimPurdum merged commit dbffbb6 into develop Jul 18, 2023
@TimPurdum TimPurdum deleted the feature/193_extra_fixes branch July 18, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seahro seahro seahro approved these changes

@AndersenBell AndersenBell Awaiting requested review from AndersenBell

Assignees

@TimPurdum TimPurdum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimPurdum @seahro