Adding measurement widget #196
Conversation
| /// </summary> | ||
| [Parameter] | ||
| [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] | ||
| public string? Icon { get; set; } |
There was a problem hiding this comment.
Does this need to be in the MeasurementWidget.cs? I saw that the both have Icon properties. Just wanted to verify.
There was a problem hiding this comment.
it should be removed from the measurement widget and inherited from the widget class
| /// </summary> | ||
| public DotNetObjectReference<MeasurementWidget> MeasurementWidgetObjectReference => DotNetObjectReference.Create(this); | ||
|
|
||
| [Parameter] |
There was a problem hiding this comment.
We need xml comments on all public types for the doc generation.
| /// </a> | ||
| /// </summary> | ||
| [JsonConverter(typeof(EnumToKebabCaseStringConverter<AreaUnit>))] | ||
| public enum AreaUnit |
There was a problem hiding this comment.
We need a better way to identify the units used in GeometryEngine vs. the ones used in the new widget. Since they changed the names on me anyways, could we create a new GeometryEngineAreaUnit, create overloads in GeometryEngine.cs that take those instead, and mark the ones that take ArealUnit as [Obsolete]?
| linearUnit: widget.linearUnit, | ||
| label: widget.label, | ||
| icon: widget.icon, | ||
| }); |
There was a problem hiding this comment.
I think this will break if you don't set all the values in the sample. The pattern I suggest is activeTool: widget.activeTool ?? undefined. This prevents setting null values in arcgis, which are sometimes not expected or handled.
| /// <a target="_blank" href="https://developers.arcgis.com/javascript/latest/api-reference/esri-widgets-Measurement.html"> | ||
| /// ArcGIS | ||
| /// JS API | ||
| /// </a> |
There was a problem hiding this comment.
you were right about this formatting, I solved it another way by fixing it in docCopy.ps1, so we can let the XML formatter do its thing.
closes #58
Adds measurement widget to the map