Feature/193 feature edits #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seahro
reviewed
Jul 13, 2023
| @@ -83,7 +83,7 @@ | |||
| <ExecAsync FilePath="pwsh" Arguments="./assetCopy.ps1" /> | |||
| </Target> | |||
|
|
|||
| <Target Name="Copy Assets Release" AfterTargets="NPM Install" Condition="$(Configuration) == 'RELEASE' AND $(TargetFrameworks.StartsWith($(TargetFramework))) AND '$(OptOutFromCoreEsBuild)' != 'true'"> | |||
| <Target Name="Copy Assets Release" AfterTargets="NPM Install" Condition="$(Configuration) == 'RELEASE' AND $(TargetFrameworks.StartsWith($(TargetFramework)))"> | |||
There was a problem hiding this comment.
Why the adjustment here on Copy Assets Release to remove `'$(OptOutFromCoreEsBuild)' != 'true'``?
There was a problem hiding this comment.
The copy assets powershell script already internally checks to see if the files are already copied, and aborts if it finds them. When I updated the ArcGIS version, I wanted this to run from Pro, but the OptOut... prevented it.
seahro
reviewed
Jul 13, 2023
| } | ||
|
|
||
| /// <summary> | ||
| /// The TextBoxInput class defines the desired user interface as a single-line text box. |
There was a problem hiding this comment.
This is essentially a placeholder(non-functioning) at this time? and require a 3rd party library/application to function correct?
seahro
reviewed
Jul 13, 2023
| } | ||
| }); | ||
| } else { | ||
| if (graphicsRefs.hasOwnProperty(target.id)) { |
There was a problem hiding this comment.
This else action seems like a duplicate.
seahro
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #193
FormTemplatecan be added to aFeatureLayer, includingFormElement,FormInput, andDomainFeatureLayer.ApplyEdits- while the related widget is in Pro, this is available programmatically to all Core usersDomaintoFieldto support form comboboxesMapViewQuery.ObjectIdsto belonginstead ofintFeatureLayersfrom updating inarcGisJsInterop.updateLayerfeatureLayerView.highlighttypescript implementationglobal.json. This should prevent breaking builds if you update your .NET SDK.