Fix popup handlers and removing graphics #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seahro
reviewed
Jun 20, 2023
| @@ -227,7 +227,13 @@ export function buildJsPopupTemplate(popupTemplateObject: DotNetPopupTemplate, v | |||
| if (viewId !== null) { | |||
| let view = arcGisObjectRefs[viewId] as View; | |||
| if (hasValue(view)) { | |||
| view.popup.on("trigger-action", async (event: PopupTriggerActionEvent) => { | |||
| if (hasValue(triggerActionHandler)) { | |||
There was a problem hiding this comment.
do we want to start to convert more null checks over to 'hasValue'? I see you have included this multiple times here and above, but still have the null checks?
There was a problem hiding this comment.
It would be a good refactoring to do, to move to always using hasValue.
seahro
reviewed
Jun 20, 2023
| @@ -1533,21 +1533,14 @@ public async Task SolveServiceArea(string serviceAreaUrl, double[] driveTimeCutO | |||
| /// </param> | |||
| public async Task RemoveGraphic(Graphic graphic) | |||
| { | |||
| try | |||
There was a problem hiding this comment.
why remove the try/catch? just to match up with the other layer and graphic methods above
There was a problem hiding this comment.
This try/catch was swallowing the exception and not exposing it to the end user, even though there was a real problem. I sometimes intentionally swallow exceptions when they are caused by say a user navigating away from the map, but in this case it was misguided.
seahro
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #181
Closes #182
Allows user to remove a graphic successfully from the
MapViewPrevents multiple registrations of the event handler in a
PopupWidgetorPopupTemplate