Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/179 pro beta #180

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Feature/179 pro beta #180

merged 4 commits into from
Jun 1, 2023

Conversation

TimPurdum
Copy link
Collaborator

Closes #179

  • Adds support for Pro library beta release
  • Minor code cleanups
  • Tested all samples

@TimPurdum TimPurdum requested a review from seahro May 29, 2023 21:37
@TimPurdum TimPurdum self-assigned this May 29, 2023
@@ -75,14 +110,42 @@ export default class FeatureLayerWrapper {
return await this.layer.queryObjectIds(jsQuery, options);
}

async queryRelatedFeatures(query: DotNetRelationshipQuery, options: any, dotNetRef: any): Promise<FeatureSet | null> {
async queryRelatedFeatures(query: DotNetRelationshipQuery, options: any, dotNetRef: any, viewId: string | null)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the queryFeatures and the queryRelatedFeatures methods do essentially the same thing since they are almost identical with the primary difference being the use of the graphicsDictionary and featureSetsDictionsary in queryRelatedFeatures because we are following the featureSets relationships vs the features themselves?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a ton of knowledge around this, I would defer to Esri's documentation or others on what the different queries mean.

@@ -132,5 +133,6 @@
private SceneView? _view;
private bool _rendered;

[SuppressMessage("ReSharper", "NotAccessedPositionalProperty.Local")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to look this up. Is there a reason to keep the testObject in this file vs put in the Shared/Pages/Tests.razor or some other file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This record is only ever used by this page, so it makes sense to make it private to the page. The attribute tells Rider/Resharper to not throw a warning that I have unused properties, when in fact they are used when serialized to JS, but Rider can't see that.

Copy link
Collaborator

@seahro seahro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions. Overall, no specific issues.

@TimPurdum TimPurdum merged commit 6c4d830 into develop Jun 1, 2023
@TimPurdum TimPurdum deleted the feature/179_pro_beta branch June 1, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to support Pro beta
2 participants