-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/179 pro beta #180
Feature/179 pro beta #180
Conversation
@@ -75,14 +110,42 @@ export default class FeatureLayerWrapper { | |||
return await this.layer.queryObjectIds(jsQuery, options); | |||
} | |||
|
|||
async queryRelatedFeatures(query: DotNetRelationshipQuery, options: any, dotNetRef: any): Promise<FeatureSet | null> { | |||
async queryRelatedFeatures(query: DotNetRelationshipQuery, options: any, dotNetRef: any, viewId: string | null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the queryFeatures
and the queryRelatedFeatures
methods do essentially the same thing since they are almost identical with the primary difference being the use of the graphicsDictionary
and featureSetsDictionsary
in queryRelatedFeatures
because we are following the featureSets relationships vs the features themselves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a ton of knowledge around this, I would defer to Esri's documentation or others on what the different queries mean.
@@ -132,5 +133,6 @@ | |||
private SceneView? _view; | |||
private bool _rendered; | |||
|
|||
[SuppressMessage("ReSharper", "NotAccessedPositionalProperty.Local")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to look this up. Is there a reason to keep the testObject in this file vs put in the Shared/Pages/Tests.razor or some other file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This record is only ever used by this page, so it makes sense to make it private to the page. The attribute tells Rider/Resharper to not throw a warning that I have unused properties, when in fact they are used when serialized to JS, but Rider can't see that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions. Overall, no specific issues.
Closes #179