Fix widgets on refresh #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #176
Simply removed the check in the
arcGisObjectRefsdictionary that was preventing re-creating widgets. I checked and none of the calls tocreateWidgetseem susceptible to rapid-calling from the blazor render cycle, so this should be fine. We can't re-use the stored widgets, however, in case the properties of the widget were changed and the goal of the refresh is to update it.On testing on
Widgets.razorin the samples app, I noticed that I also needed to add logic to clear out existing widgets placed outside of the map view in container divs.