Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for Graphic AttributesDictionary #175

Merged
merged 1 commit into from
May 28, 2023

Conversation

TimPurdum
Copy link
Collaborator

Closes #174

  • We couldn't use EventCallback for non-blazor-rendered components, it throws an exception. Replaced with Func<Task>
  • Re-added a setter for the indexer AttributesDictionary[key] = value, but with an Obsolete tag, because this requires calling the async delegate from sync code
  • Added a convenience method AddOrUpdate(newDictionary) to AttributesDictionary

@TimPurdum TimPurdum requested review from seahro and AndersenBell May 20, 2023 00:38
@TimPurdum TimPurdum self-assigned this May 20, 2023
@TimPurdum
Copy link
Collaborator Author

Merging after significant personal testing.

@TimPurdum TimPurdum merged commit a62072a into develop May 28, 2023
@TimPurdum TimPurdum deleted the bug/174_c_sharp_attributes branch May 28, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphic.Attributes not supporting C# initialization
1 participant