Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/163 geometry methods #171

Merged
merged 4 commits into from
May 19, 2023
Merged

Feature/163 geometry methods #171

merged 4 commits into from
May 19, 2023

Conversation

TimPurdum
Copy link
Collaborator

Closes #163

  • Implements all missing geometry-related methods, but moves them all to the GeometryEngine
  • Documents implementation and how it differs from ArcGIS in new docs page
  • New samples page GeometryMethods.razor tests many of the new methods in GeometryEngine

@TimPurdum TimPurdum requested review from seahro and AndersenBell May 13, 2023 19:41
@TimPurdum TimPurdum self-assigned this May 13, 2023
@TimPurdum TimPurdum mentioned this pull request May 16, 2023
Merged
AndersenBell
AndersenBell approved these changes May 19, 2023
View reviewed changes
Copy link
Collaborator

@AndersenBell AndersenBell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@TimPurdum TimPurdum merged commit 1067a8f into develop May 19, 2023
@TimPurdum TimPurdum deleted the feature/163_geometry_methods branch May 19, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersenBell AndersenBell AndersenBell approved these changes

@seahro seahro Awaiting requested review from seahro

Assignees

@TimPurdum TimPurdum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing methods to Extent
2 participants
@TimPurdum @AndersenBell