Update samples to .NET 7, fix asset path to be relative #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seahro
reviewed
Apr 14, 2023
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <MauiImage Include="Resources\Splash\geoblazor.png"/> | ||
| <Content Remove="appsettings.json" /> |
There was a problem hiding this comment.
I will need to remember this, will we need a appsettings.development.json here also?
There was a problem hiding this comment.
It's not necessary, unless we wanted one. I just wanted one file to demonstrate that appsettings do work for MAUI.
seahro
approved these changes
Apr 14, 2023
@seahro this would be awesome if you could test MAUI iOS and MAUI Mac deployments for us at some point! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #155. Also updates samples projects to target .NET 7.
After discussion, I removed the
.in the asset path and tested all the sample applications. They still functioned correctly in WASM, MAUI, and Server. I also added a reminder in theassetFiles.mddocs page about setting the "base" path in html.