-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teams review support #19
Conversation
@volas sorry to let this slip through the cracks. Is this something you're still interested in driving? I assume the |
@dyladan no problem, I was using this on my fork and dropped this here just in case if someone else interested. I have updated it to use "org-name/" as team prefix. And also updated Readme.md with instruction about using personal access token instead of |
README.md
Outdated
|
||
1. Just follow [Github's instructions](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#creating-a-fine-grained-personal-access-token) and add a new token with the following set of permissions: | ||
|
||
![perm](https://github.com/volas/component-owners/assets/4064061/474022d1-820a-48c6-8100-a8553584e961) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this PR gets merged this should point to the upstream repo or have a link independent of the repo name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced it with a markdown table.
Also removed Discussions prem as it was unnecessary, I think.
Thank you @volas! We are looking for the same functionality, so glad to see you already worked on that. |
FYI, I did a small test run for my PR towards opentelemetry.io, it seems to work: https://github.com/svrnm/opentelemetry.io/actions/runs/9791445867/job/27035250030 There have been no reviewers assigned since it checked for |
Co-authored-by: Severin Neumann <neumanns@cisco.com>
Adds support for team review:
But it does not work with standard
github.token
, for some reason github needs more permissions forteam_reviewers
("Could not resolve to a node with the global id of ..." error or something). I have updated README with steps for generating and using own token for this.