Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teams review support #19

Merged
merged 7 commits into from
Jul 11, 2024
Merged

Teams review support #19

merged 7 commits into from
Jul 11, 2024

Conversation

volas
Copy link
Contributor

@volas volas commented Oct 26, 2023

Adds support for team review:

components:
  src/example.ts: org-name/team-name

But it does not work with standard github.token, for some reason github needs more permissions for team_reviewers ("Could not resolve to a node with the global id of ..." error or something). I have updated README with steps for generating and using own token for this.

@dyladan
Copy link
Owner

dyladan commented Jun 10, 2024

@volas sorry to let this slip through the cracks. Is this something you're still interested in driving? I assume the / prefix is to disambiguate from usernames in text? What about org-name/team-name like github normally does? I know the org name will always be the same but I think reading it will be more obvious to most people.

@volas
Copy link
Contributor Author

volas commented Jun 11, 2024

@dyladan no problem, I was using this on my fork and dropped this here just in case if someone else interested.

I have updated it to use "org-name/" as team prefix.

And also updated Readme.md with instruction about using personal access token instead of github.token, because else action don't have permissions to request team review. This part can be little complicated.

README.md Outdated

1. Just follow [Github's instructions](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#creating-a-fine-grained-personal-access-token) and add a new token with the following set of permissions:

![perm](https://github.com/volas/component-owners/assets/4064061/474022d1-820a-48c6-8100-a8553584e961)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR gets merged this should point to the upstream repo or have a link independent of the repo name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced it with a markdown table.

Also removed Discussions prem as it was unnecessary, I think.

README.md Outdated Show resolved Hide resolved
@svrnm
Copy link
Contributor

svrnm commented Jul 4, 2024

Thank you @volas! We are looking for the same functionality, so glad to see you already worked on that.

@svrnm
Copy link
Contributor

svrnm commented Jul 4, 2024

FYI, I did a small test run for my PR towards opentelemetry.io, it seems to work:

https://github.com/svrnm/opentelemetry.io/actions/runs/9791445867/job/27035250030

There have been no reviewers assigned since it checked for open-telemetry/team-name which of course is not available in my privat repo.

volas and others added 2 commits July 5, 2024 07:06
Co-authored-by: Severin Neumann <neumanns@cisco.com>
@dyladan dyladan merged commit 58bd86e into dyladan:main Jul 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants