Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bonsai-ui): market header and launchable market details #1400

Merged
merged 15 commits into from
Jan 22, 2025
Merged

feat(bonsai-ui): market header and launchable market details #1400

merged 15 commits into from
Jan 22, 2025

Conversation

jaredvu
Copy link
Contributor

@jaredvu jaredvu commented Jan 6, 2025

Migrate market headers and details

Views

  • <LaunchableMarketStatsDetails> & <LaunchableMarketDetails>

    • use BonsaiHelper createSelect

  • <MarketStatsDetails>

    • use BonsaiHelper and BonsaiCore

Functions/Clients

  • lib/ontology
    • add to BonsaiHelper

@jaredvu jaredvu requested a review from a team as a code owner January 6, 2025 22:29
@vercel Vercel
Copy link

vercel bot commented Jan 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 10:59pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 10:59pm

@jaredvu jaredvu changed the title chore(bonsai-ui): market header and launchable market details feat(bonsai-ui): market header and launchable market details Jan 6, 2025
tyleroooo
tyleroooo reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@tyleroooo tyleroooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you thank you thank you, just a few thoughts

src/abacus-ts/ontology.ts Outdated Show resolved Hide resolved
src/views/MarketStatsDetails.tsx Outdated Show resolved Hide resolved
@jaredvu jaredvu requested a review from tyleroooo January 22, 2025 19:30
@jaredvu jaredvu enabled auto-merge (squash) January 22, 2025 19:36
@jaredvu jaredvu requested a review from tyleroooo January 22, 2025 22:58
@jaredvu jaredvu merged commit f02484a into main Jan 22, 2025
9 checks passed
@jaredvu jaredvu deleted the jared/ui-market-header branch January 22, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyleroooo tyleroooo tyleroooo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredvu @tyleroooo