Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subaccount usernames table to list of tables to export. #2677

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

vincentwschau
Copy link
Contributor

@vincentwschau vincentwschau commented Jan 8, 2025

Changelist

Add DDL for subaccount usernames table to research env export task.

Test Plan

N/A

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features

    • Added support for generating Athena table creation statements for subaccount usernames.
    • Expanded table creation capabilities in the research environment update process.
  • Chores

    • Integrated new module for handling subaccount username table definitions.

@vincentwschau vincentwschau requested a review from a team as a code owner January 8, 2025 20:22
Copy link
Contributor

coderabbitai bot commented Jan 8, 2025

Walkthrough

This pull request introduces a new TypeScript module for generating Athena table creation statements specifically for subaccount usernames. The module defines constants for the table name and columns, and provides two functions: generateRawTable and generateTable. These functions create SQL statements for external and standard Athena tables respectively. The changes are integrated into the update-research-environment task, adding a new entry for subaccount usernames to the Athena table creation process.

Changes

File Change Summary
indexer/services/roundtable/src/lib/athena-ddl-tables/subaccount_usernames.ts Added new module with:
- TABLE_NAME constant
- RAW_TABLE_COLUMNS constant
- TABLE_COLUMNS constant
- generateRawTable(tablePrefix: string, rdsExportIdentifier: string): string function
- generateTable(tablePrefix: string): string function
indexer/services/roundtable/src/tasks/update-research-environment.ts Added import for athenaSubaccountUsernames
Added subaccount_usernames: athenaSubaccountUsernames to tablesToAddToAthena

Possibly related PRs

Suggested reviewers

  • shrenujb

Poem

🐰 Hop, hop, into Athena's realm,
Subaccount usernames now take the helm!
Tables spinning, data gleaming bright,
SQL statements dancing with delight!
A rabbit's code, precise and clean,
Indexing magic on the data scene! 🔍


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8790e0 and bc6196b.

📒 Files selected for processing (1)
  • indexer/services/roundtable/src/tasks/update-research-environment.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • indexer/services/roundtable/src/tasks/update-research-environment.ts
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: test / run_command
  • GitHub Check: Summary

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vincentwschau vincentwschau merged commit b2674f5 into main Jan 8, 2025
16 checks passed
@vincentwschau vincentwschau deleted the vincentc/export-subaccount-usernames-table branch January 8, 2025 22:23
@vincentwschau
Copy link
Contributor Author

@Mergifyio backport release/indexer/v7.x

Copy link
Contributor

mergify bot commented Jan 8, 2025

backport release/indexer/v7.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 8, 2025
vincentwschau added a commit that referenced this pull request Jan 8, 2025
…2677) (#2679)

Co-authored-by: vincentwschau <99756290+vincentwschau@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants