Remove orderbook cache roundtable job

[adamfraser]

Changelist

Removed unused Roundtable job that cached orderbook mid prices. This will be re-added at a later date after the implementation has been improved.

Test Plan

Manually tested in dev

Summary by CodeRabbit

• New Features

  • No new features introduced.

• Bug Fixes

  • No bug fixes implemented.

• Chores

  • Removed the configuration entry for caching order book mid prices.
  • Deleted the task and associated code for caching order book mid prices.
  • Removed related unit tests for the caching functionality.

• Documentation

  • Updated configuration schema to reflect the removal of the caching entry.

[coderabbitai]

Walkthrough

The changes in this pull request involve the removal of the LOOPS_ENABLED_CACHE_ORDERBOOK_MID_PRICES configuration entry from the configSchema, leading to the deletion of the cacheOrderbookMidPrices task and its associated implementation. Additionally, the file responsible for executing this task, cache-orderbook-mid-prices.ts, has been removed along with its unit tests. The overall structure of the remaining configuration and tasks remains unchanged.

Changes

File Path	Change Summary
indexer/services/roundtable/src/config.ts	Removed configuration entry: LOOPS_ENABLED_CACHE_ORDERBOOK_MID_PRICES
indexer/services/roundtable/src/index.ts	Removed task: cacheOrderbookMidPrices and related configuration checks
indexer/services/roundtable/src/tasks/cache-orderbook-mid-prices.ts	Deleted file containing runTask function for updating OrderbookMidPricesCache
indexer/services/roundtable/__tests__/tasks/cache-orderbook-mid-prices.test.ts	Deleted unit tests for runTask function related to orderbook mid prices caching

Possibly related PRs

• Add Orderbook Mid Price Cache #2289: Introduces a caching mechanism for orderbook mid prices using Redis, directly related to the removal of the LOOPS_ENABLED_CACHE_ORDERBOOK_MID_PRICES configuration.
• Revert "Add Orderbook Mid Price Cache (#2289)" #2333: Reverts changes made in PR Add Orderbook Mid Price Cache #2289, impacting the context of the main PR's changes.
• Add Orderbook Mid Price Cache #2338: Reintroduces the orderbook mid price caching mechanism, aligning with the configuration and task management changes in the main PR.

Suggested labels

bug

Suggested reviewers

• dydxwill

🐇 In the meadow, changes bloom,
The old tasks fade, make room!
No more loops to cache the price,
A fresh start, oh so nice!
With hops and bounds, we'll find our way,
To brighter paths, come what may! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e4aa393 and 4ef7e5c.

📒 Files selected for processing (4)

• indexer/services/roundtable/tests/tasks/cache-orderbook-mid-prices.test.ts (0 hunks)
• indexer/services/roundtable/src/config.ts (0 hunks)
• indexer/services/roundtable/src/index.ts (0 hunks)
• indexer/services/roundtable/src/tasks/cache-orderbook-mid-prices.ts (0 hunks)

💤 Files with no reviewable changes (4)

• indexer/services/roundtable/tests/tasks/cache-orderbook-mid-prices.test.ts
• indexer/services/roundtable/src/config.ts
• indexer/services/roundtable/src/index.ts
• indexer/services/roundtable/src/tasks/cache-orderbook-mid-prices.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[adamfraser]

@mergify backport release/indexer/v7.x

[mergify]

backport release/indexer/v7.x

✅ Backports have been created

• #2511 Remove orderbook cache roundtable job (backport #2510) has been created for branch release/indexer/v7.x