-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTE-877] deprecate OI indexer update event #2499
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -1372,31 +1372,47 @@ export interface AddressTradingRewardSDKType { | |||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
denom_amount: Uint8Array; | ||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||
/** OpenInterestUpdateEventV1 is used for open interest update events */ | ||||||||||||||||||||||||||||||||||
/** | ||||||||||||||||||||||||||||||||||
* OpenInterestUpdateEventV1 is used for open interest update events | ||||||||||||||||||||||||||||||||||
* Deprecated. | ||||||||||||||||||||||||||||||||||
*/ | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
/** @deprecated */ | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
export interface OpenInterestUpdateEventV1 { | ||||||||||||||||||||||||||||||||||
/** The list of all open interest updates in the block. */ | ||||||||||||||||||||||||||||||||||
openInterestUpdates: OpenInterestUpdate[]; | ||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||
/** OpenInterestUpdateEventV1 is used for open interest update events */ | ||||||||||||||||||||||||||||||||||
/** | ||||||||||||||||||||||||||||||||||
* OpenInterestUpdateEventV1 is used for open interest update events | ||||||||||||||||||||||||||||||||||
* Deprecated. | ||||||||||||||||||||||||||||||||||
*/ | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
/** @deprecated */ | ||||||||||||||||||||||||||||||||||
Comment on lines
+1385
to
+1390
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Combine Similarly, include the Apply this diff: /**
* OpenInterestUpdateEventV1 is used for open interest update events
* Deprecated.
+ * @deprecated
*/
- /** @deprecated */
export interface OpenInterestUpdateEventV1SDKType {
open_interest_updates: OpenInterestUpdateSDKType[];
} 📝 Committable suggestion
Suggested change
|
||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
export interface OpenInterestUpdateEventV1SDKType { | ||||||||||||||||||||||||||||||||||
/** The list of all open interest updates in the block. */ | ||||||||||||||||||||||||||||||||||
open_interest_updates: OpenInterestUpdateSDKType[]; | ||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||
/** OpenInterestUpdate contains a single open interest update for a perpetual */ | ||||||||||||||||||||||||||||||||||
/** | ||||||||||||||||||||||||||||||||||
* OpenInterestUpdate contains a single open interest update for a perpetual | ||||||||||||||||||||||||||||||||||
* Deprecated. | ||||||||||||||||||||||||||||||||||
*/ | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
/** @deprecated */ | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
export interface OpenInterestUpdate { | ||||||||||||||||||||||||||||||||||
/** The ID of the perpetual market. */ | ||||||||||||||||||||||||||||||||||
perpetualId: number; | ||||||||||||||||||||||||||||||||||
/** The new open interest value for the perpetual market. */ | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
Comment on lines
+1399
to
1405
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Include For Apply this diff: /**
* OpenInterestUpdate contains a single open interest update for a perpetual
* Deprecated.
+ * @deprecated
*/
- /** @deprecated */
export interface OpenInterestUpdate {
perpetualId: number;
/** The new open interest value for the perpetual market. */ 📝 Committable suggestion
Suggested change
|
||||||||||||||||||||||||||||||||||
openInterest: Uint8Array; | ||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||
/** OpenInterestUpdate contains a single open interest update for a perpetual */ | ||||||||||||||||||||||||||||||||||
/** | ||||||||||||||||||||||||||||||||||
* OpenInterestUpdate contains a single open interest update for a perpetual | ||||||||||||||||||||||||||||||||||
* Deprecated. | ||||||||||||||||||||||||||||||||||
*/ | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
/** @deprecated */ | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
export interface OpenInterestUpdateSDKType { | ||||||||||||||||||||||||||||||||||
/** The ID of the perpetual market. */ | ||||||||||||||||||||||||||||||||||
perpetual_id: number; | ||||||||||||||||||||||||||||||||||
/** The new open interest value for the perpetual market. */ | ||||||||||||||||||||||||||||||||||
Comment on lines
+1412
to
1417
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Include Similarly, for Apply this diff: /**
* OpenInterestUpdate contains a single open interest update for a perpetual
* Deprecated.
+ * @deprecated
*/
- /** @deprecated */
export interface OpenInterestUpdateSDKType {
perpetual_id: number;
/** The new open interest value for the perpetual market. */ 📝 Committable suggestion
Suggested change
|
||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
|
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Combine
@deprecated
annotation with the JSDoc comment blockThe
@deprecated
tag forOpenInterestUpdateEventV1
should be included within the JSDoc comment block to properly document the deprecation.Apply this diff:
📝 Committable suggestion
💡 Codebase verification
Deprecated Interfaces Still in Use
The deprecated interfaces
OpenInterestUpdateEventV1
andOpenInterestUpdate
are still being used in the fileindexer/services/ender/__tests__/helpers/constants.ts
. Please remove these usages to complete the deprecation process.🔗 Analysis chain
Verify that deprecated interfaces are no longer used in the codebase
Now that
OpenInterestUpdateEventV1
andOpenInterestUpdate
have been deprecated, ensure that they are not used elsewhere in the codebase.Run the following script to check for usage:
Also applies to: 1399-1405
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 726