Fix issue with flaky candle test

[adamfraser]

Changelist

Modifies candles generator test to using a starting time far enough in the past to ensure candles are started before the current candle

Test Plan

Automated tests passing

Summary by CodeRabbit

• Tests
  • Enhanced the test suite for candle generation with new test cases and updates to existing ones.
  • Improved coverage for scenarios involving historical timestamps.
  • Refactored candle creation logic for accuracy in properties based on trade conditions.
  • Added helper functions for better readability and maintainability of test code.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request focus on enhancing the test suite for the CandlesGenerator functionality within the candles-generator.test.ts file. Modifications include the addition of new test cases, updates to existing tests, and refactoring of candle creation logic. The updates aim to improve coverage, particularly for scenarios involving historical timestamps and the interaction between trades and candle updates, ensuring accurate assertions and streamlined helper functions for verification.

Changes

File Path	Change Summary
indexer/services/ender/__tests__/lib/candles-generator.test.ts	- Added new test cases for candle generation with past timestamps. - Updated existing tests for candle creation and updates. - Refactored candle creation logic for accuracy. - Enhanced assertions for database state and Kafka messages. - Introduced helper functions for improved test readability.

Possibly related PRs

• Candles HLOC Data #1887: Introduces orderbookMidPriceOpen and orderbookMidPriceClose fields related to enhancements in the candle generation logic.
• Adam/ct 1059 address issue with orderbookmidprice calculation #2012: Addresses issues with the calculation of orderbookMidPrice, relevant to the candle generation logic.

Suggested labels

bug

Suggested reviewers

• dydxwill
• tqin7

Poem

In the garden of code, where candles grow bright,
New tests are planted, a wonderful sight.
With timestamps from past, they dance and they sway,
Ensuring our candles are crafted the right way.
So hop with delight, let the assertions take flight,
For our candles now shine with a glorious light! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.