Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove open interest handler #2319

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Remove open interest handler #2319

merged 2 commits into from
Sep 23, 2024

Conversation

dydxwill
Copy link
Contributor

@dydxwill dydxwill commented Sep 23, 2024

Changelist

Open interest is being calculated in a roundtable task.
Can ignore these events from protocol.

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • Bug Fixes

    • Removed obsolete handling and validation for open interest updates, streamlining event processing.
  • New Features

    • No new features were introduced in this release.
  • Chores

    • Deleted multiple files and handlers related to open interest updates to enhance code maintainability.

@dydxwill dydxwill requested a review from a team as a code owner September 23, 2024 16:13
Copy link
Contributor

coderabbitai bot commented Sep 23, 2024

Walkthrough

The pull request involves the removal of the OpenInterestUpdateHandler and all associated components, including its validator, SQL handler, and related tests. This change eliminates the functionality for processing open interest update events in a trading context, affecting how these events are handled throughout the system. Various files, such as handlers, validators, and SQL scripts, have been updated to reflect this removal.

Changes

File Path Change Summary
indexer/services/ender/__tests__/handlers/open-interest-update-handler.test.ts Deleted test suite for openInterestUpdateHandler, including setup, teardown, and assertions.
indexer/services/ender/src/handlers/open-interest-update-handler.ts Removed OpenInterestUpdateHandler class and its methods for processing open interest updates.
indexer/services/ender/src/helpers/postgres/postgres-functions.ts Removed SQL handler script 'dydx_open_interest_update_handler.sql' from HANDLER_SCRIPTS array.
indexer/services/ender/src/lib/block-processor.ts Removed OpenInterestUpdateValidator from import statements and event subtype mapping.
indexer/services/ender/src/lib/helper.ts Deleted case for handling DydxIndexerSubtypes.OPEN_INTEREST_UPDATE in event processing function.
indexer/services/ender/src/lib/types.ts Removed OPEN_INTEREST_UPDATE subtype from DydxIndexerSubtypes enum and updated related type definitions.
indexer/services/ender/src/scripts/handlers/dydx_block_processor_ordered_handlers.sql Removed handler for "open_interest_update" event type from SQL script.
indexer/services/ender/src/scripts/handlers/dydx_open_interest_update_handler.sql Deleted SQL function dydx_open_interest_update_handler for processing open interest updates.
indexer/services/ender/src/validators/open-interest-update-validator.ts Removed OpenInterestUpdateValidator class responsible for validating open interest update events.

Possibly related PRs

Poem

In the garden where traders play,
The open interest has gone away.
No more updates to track and chase,
Just peaceful fields in this quiet space.
Hops and dreams in the market's sway,
A new dawn breaks, brightening the day! 🐇✨


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4f090d0 and 3a9615f.

Files selected for processing (2)
  • indexer/services/ender/src/lib/helper.ts (0 hunks)
  • indexer/services/ender/src/lib/types.ts (0 hunks)
Files not reviewed due to no reviewable changes (2)
  • indexer/services/ender/src/lib/helper.ts
  • indexer/services/ender/src/lib/types.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dydxwill dydxwill merged commit 06eeb77 into main Sep 23, 2024
16 checks passed
@dydxwill dydxwill deleted the wl/rm_open_interest_handler branch September 23, 2024 16:32
@dydxwill
Copy link
Contributor Author

@Mergifyio backport release/indexer/v5.x

@dydxwill
Copy link
Contributor Author

@Mergifyio backport release/indexer/v6.x

Copy link
Contributor

mergify bot commented Sep 23, 2024

backport release/indexer/v5.x

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 23, 2024

backport release/indexer/v6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 23, 2024
(cherry picked from commit 06eeb77)

# Conflicts:
#	indexer/services/ender/src/lib/block-processor.ts
#	indexer/services/ender/src/lib/helper.ts
#	indexer/services/ender/src/lib/types.ts
#	indexer/services/ender/src/scripts/handlers/dydx_block_processor_ordered_handlers.sql
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
(cherry picked from commit 06eeb77)

# Conflicts:
#	indexer/services/ender/src/lib/block-processor.ts
#	indexer/services/ender/src/lib/helper.ts
#	indexer/services/ender/src/lib/types.ts
#	indexer/services/ender/src/scripts/handlers/dydx_block_processor_ordered_handlers.sql
dydxwill added a commit that referenced this pull request Sep 23, 2024
Co-authored-by: dydxwill <119354122+dydxwill@users.noreply.github.com>
Co-authored-by: Will Liu <will@dydx.exchange>
dydxwill added a commit that referenced this pull request Sep 23, 2024
Co-authored-by: dydxwill <119354122+dydxwill@users.noreply.github.com>
Co-authored-by: Will Liu <will@dydx.exchange>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants