Remove uncommitted stateful orders from equity tier check #1569

jonfung-dydx · 2024-05-22T20:23:30Z

remove the read path for uncommitted stateful orders
remove the tests that fail

further pr will remove write path

Summary by CodeRabbit

Bug Fixes
- Improved validation process for stateful orders, ensuring smoother transaction handling.
- Removed outdated logic for managing uncommitted stateful orders in transactions, enhancing system efficiency.
Tests
- Updated test scenarios to reflect the removal of limits on maximum open stateful orders within a block.
- Adjusted test data and configurations to align with the new equity tier limit validations.

coderabbitai · 2024-05-22T20:23:36Z

Walkthrough

The changes across the files aim to streamline and simplify the codebase within the protocol/x/clob/keeper package. These modifications enhance the efficiency of the validation process for stateful orders by removing unnecessary imports, eliminating complex logic related to uncommitted stateful orders, and adjusting test cases and configurations for equity tier limits.

Changes

File Path	Change Summary
`protocol/x/clob/keeper/equity_tier_limit.go`	- Removed unused import: `fmt` - Simplified validation process for stateful orders by eliminating logic for uncommitted stateful orders in `CheckTx` mode
`protocol/x/clob/e2e/equity_tier_limit_test.go`	- Removed test cases for orders exceeding the maximum open stateful orders in the same block - Adjusted test data and configurations for equity tier limits

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ab1ab54 and ca71949.

Files selected for processing (1)

protocol/x/clob/keeper/equity_tier_limit.go (3 hunks)

Files skipped from review due to trivial changes (1)

protocol/x/clob/keeper/equity_tier_limit.go

jonfung-dydx · 2024-05-22T20:34:08Z

https://linear.app/dydx/issue/CT-866/remove-write-path-for-uncommitted-stateful-orders

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ca71949 and 24f1e91.

Files selected for processing (1)

protocol/x/clob/e2e/equity_tier_limit_test.go (1 hunks)

Files skipped from review due to trivial changes (1)

protocol/x/clob/e2e/equity_tier_limit_test.go

jayy04 · 2024-05-23T22:13:56Z

protocol/x/clob/keeper/equity_tier_limit.go

@@ -162,24 +160,6 @@ func (k Keeper) ValidateSubaccountEquityTierLimitForStatefulOrder(ctx sdk.Contex
 	}

 	equityTierCount := k.GetStatefulOrderCount(ctx, order.OrderId.SubaccountId)
-	// If this is `CheckTx` then we must also add the number of uncommitted stateful orders that this validator
-	// is aware of (orders that are part of the mempool but have yet to proposed in a block).
-	if !lib.IsDeliverTxMode(ctx) {


just to make sure - we still have the onchain equity tier limit check in deliver tx, right?

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 24f1e91 and ca5acbc.

Files selected for processing (2)

protocol/x/clob/keeper/orders.go (2 hunks)
protocol/x/clob/keeper/uncommitted_stateful_order_state.go (2 hunks)

Additional Context Used

Path-based Instructions (2)

protocol/x/clob/keeper/uncommitted_stateful_order_state.go (1)

Pattern **/**: Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.

protocol/x/clob/keeper/orders.go (1)

Pattern **/**: Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.

Additional comments not posted (2)

protocol/x/clob/keeper/uncommitted_stateful_order_state.go (1)

Line range hint 106-106: LGTM! The function MustAddUncommittedStatefulOrderCancellation correctly handles the addition of new order cancellations and decrements the order count.

protocol/x/clob/keeper/orders.go (1)

Line range hint 106-106: LGTM! The function PerformOrderCancellationStatefulValidation correctly performs all necessary checks to validate an order cancellation.

jonfung-dydx · 2024-05-24T18:45:22Z

TODO: remove GetUncommittedStatefulOrderCancellation

remove uncommitted stateful orders from equity tier check

ca71949

github-actions bot added the protocol label May 22, 2024

coderabbitai bot reviewed May 22, 2024

View reviewed changes

remove tests

24f1e91

coderabbitai bot reviewed May 22, 2024

View reviewed changes

jayy04 reviewed May 23, 2024

View reviewed changes

jayy04 approved these changes May 23, 2024

View reviewed changes

coderabbitai bot reviewed May 24, 2024

View reviewed changes

jonfung-dydx force-pushed the jonfung/removeUncommittedEquityTierLimit branch from ca5acbc to 24f1e91 Compare May 24, 2024 18:34

jonfung-dydx merged commit 5662a8b into main May 24, 2024
32 checks passed

jonfung-dydx deleted the jonfung/removeUncommittedEquityTierLimit branch May 24, 2024 18:54

coderabbitai bot mentioned this pull request Oct 1, 2024

[CT-1202] logic to handle unauthorized maker orders when authenticato… #2412

Merged

6 tasks

coderabbitai bot mentioned this pull request Nov 27, 2024

[CT-1327] place post only orders first in prepare check state #2618

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove uncommitted stateful orders from equity tier check #1569

Remove uncommitted stateful orders from equity tier check #1569

jonfung-dydx commented May 22, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 22, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

jonfung-dydx commented May 22, 2024

coderabbitai bot left a comment

jayy04 May 23, 2024

coderabbitai bot left a comment

jonfung-dydx commented May 24, 2024

Remove uncommitted stateful orders from equity tier check #1569

Remove uncommitted stateful orders from equity tier check #1569

Conversation

jonfung-dydx commented May 22, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented May 22, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

jonfung-dydx commented May 22, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

jayy04 May 23, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

jonfung-dydx commented May 24, 2024

jonfung-dydx commented May 22, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 22, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)