[CT-1338] Add channel and id properties to error message on subscript…

…ion failure. (#2678)
dydxprotocol · Jan 8, 2025 · 4cdfae6 · 4cdfae6
1 parent 2a79ca0
commit 4cdfae6
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 0 deletions.
diff --git a/indexer/services/socks/__tests__/lib/subscriptions.test.ts b/indexer/services/socks/__tests__/lib/subscriptions.test.ts
@@ -244,6 +244,8 @@ describe('Subscriptions', () => {
           message: expect.stringContaining(
             `Internal error, could not fetch data for subscription: ${Channel.V4_ACCOUNTS}`,
           ),
+          channel: Channel.V4_ACCOUNTS,
+          id: mockSubaccountId,
         }));
       expect(subscriptions.subscriptions[Channel.V4_ACCOUNTS]).toBeUndefined();
       expect(subscriptions.subscriptionLists[connectionId]).toBeUndefined();
@@ -278,6 +280,8 @@ describe('Subscriptions', () => {
           connection_id: connectionId,
           type: 'error',
           message: expectedError.message,
+          channel: Channel.V4_ACCOUNTS,
+          id: mockSubaccountId,
         }));
       expect(subscriptions.subscriptions[Channel.V4_ACCOUNTS]).toBeUndefined();
       expect(subscriptions.subscriptionLists[connectionId]).toBeUndefined();

diff --git a/indexer/services/socks/src/helpers/message.ts b/indexer/services/socks/src/helpers/message.ts
@@ -13,12 +13,16 @@ export function createErrorMessage(
   message: string,
   connectionId: string,
   messageId: number,
+  channel?: string,
+  id?: string,
 ): ErrorMessage {
   return {
     type: OutgoingMessageType.ERROR,
     message,
     connection_id: connectionId,
     message_id: messageId,
+    channel,
+    id,
   };
 }
 

diff --git a/indexer/services/socks/src/lib/subscription.ts b/indexer/services/socks/src/lib/subscription.ts
@@ -172,6 +172,8 @@ export class Subscriptions {
           errorMsg,
           connectionId,
           messageId,
+          channel,
+          id,
         ),
       );
 

diff --git a/indexer/services/socks/src/types.ts b/indexer/services/socks/src/types.ts
@@ -67,6 +67,8 @@ export interface OutgoingMessage {
 
 export interface ErrorMessage extends OutgoingMessage {
   message: string,
+  channel?: string,
+  id?: string,
 }
 
 export interface SubscribedMessage extends OutgoingMessage {