-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-538] Apply dYdX patches to Cosmos SDK 0.50.1 fork #30
Changes from 1 commit
05df267
9510f1c
c0b38c4
f233d7f
6a977c9
c338245
9c28897
02d061c
acaae16
89d0d11
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
This change pushes the mutex that was in the local client to the top level of the ABCI methods and uses the unsynchronized local client. A future change is intended to reduce the critical sections of the various ABCI methods. We also replace cometbft usage with dYdX fork.
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -6,6 +6,7 @@ import ( | |||||||||||||||||||||||||
"math" | ||||||||||||||||||||||||||
"sort" | ||||||||||||||||||||||||||
"strconv" | ||||||||||||||||||||||||||
"sync" | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
"github.com/cockroachdb/errors" | ||||||||||||||||||||||||||
abci "github.com/cometbft/cometbft/abci/types" | ||||||||||||||||||||||||||
|
@@ -184,6 +185,9 @@ type BaseApp struct { | |||||||||||||||||||||||||
// including the goroutine handling.This is experimental and must be enabled | ||||||||||||||||||||||||||
// by developers. | ||||||||||||||||||||||||||
optimisticExec *oe.OptimisticExecution | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
// Used to synchronize the application when using an unsynchronized ABCI++ client. | ||||||||||||||||||||||||||
mtx sync.Mutex | ||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Question on I see that on Lines 418 to 429 in bdf96fd
DeliverTx . How has this changed in v0.50 ? This is the corresponding deliverTx function - is it intended to not take the lock?
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cosmos was re-entrant when delivering txs during block commit which is why we needed the ability to selectively take the lock. CometBFT pushed down block commit logic of individually calling There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the explanation. I see from here tha |
||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
// NewBaseApp returns a reference to an initialized BaseApp. It accepts a | ||||||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: do we still need the
commiter
logic from here? Or is that replaced by theprepareCheckStater
below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is replaced by
prepareCheckStater
which @prettymuchbryce pushed upstream as the replacement for thecommitter
logic.