Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a version command #159

Open
RobjS opened this issue Jun 30, 2021 · 3 comments
Open

Add a version command #159

RobjS opened this issue Jun 30, 2021 · 3 comments
Labels
enhancement

Comments

@RobjS
Copy link
Contributor

RobjS commented Jun 30, 2021

So a user can run e.g. whippet version or whippet -v to get info on what version they're running.
@snim2
Copy link
Contributor

snim2 commented Nov 1, 2022

How were you anticipating the version information would be stored?

@RobjS
Copy link
Contributor Author

RobjS commented Nov 2, 2022

I hadn't really thought that far ahead! I guess maybe either in https://github.com/dxw/whippet/blob/main/src/Whippet.php, or in a file in a config/ folder? Probably as a protected property, or something along those lines.

patdel0 added a commit that referenced this issue Feb 6, 2023
@patdel0
Add version commmand
78187f1 
All packages installed with brew have the version of the package in the
name of the parent folder. Whereas those installed from source have the
git tags present.

With that in mind, either the git tags or parent folder name is referenced to
print the release version used.

Relates: #159
@snim2
Copy link
Contributor

snim2 commented Aug 12, 2024

Note the enhancement/version-command-to-return-whippet-version branch contains some work for this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snim2 @RobjS