Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detail and examples to redirect guidance #1071

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

yndajas
Copy link
Member

@yndajas yndajas commented Feb 3, 2023

This explains the different uses of the two redirect methods in more detail, and provides examples of situations in which you would each one

@netlify
Copy link

netlify bot commented Feb 3, 2023

Deploy Preview for laughing-payne-b9fbd2 ready!

Name Link
🔨 Latest commit 801609a
🔍 Latest deploy log https://app.netlify.com/sites/laughing-payne-b9fbd2/deploys/63dd2f39ae13730009d5f59a
😎 Deploy Preview https://deploy-preview-1071--laughing-payne-b9fbd2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

This explains the different uses of the two redirect methods in more
detail, and provides examples of situations in which you would each one
@yndajas yndajas force-pushed the more-detailed-redirect-guidance branch from 4537d97 to 801609a Compare February 3, 2023 15:58
@yndajas yndajas requested a review from snim2 February 9, 2023 11:29
Copy link
Contributor

@snim2 snim2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and I don't want to block it from being merged, but I wonder whether we need a slightly different set of docs for colleagues who use the CMS on the README?

@yndajas
Copy link
Member Author

yndajas commented Feb 9, 2023

This looks good to me, and I don't want to block it from being merged, but I wonder whether we need a slightly different set of docs for colleagues who use the CMS on the README?

Do you mean we'd move any detailed stuff for devs more into the README, and leave the rest (CMS) in the contributing guide?

@snim2
Copy link
Contributor

snim2 commented Feb 9, 2023

This looks good to me, and I don't want to block it from being merged, but I wonder whether we need a slightly different set of docs for colleagues who use the CMS on the README?

Do you mean we'd move any detailed stuff for devs more into the README, and leave the rest (CMS) in the contributing guide?

Oh that's a really good point. I guess non-technical people will look at the site and not the README?

@yndajas
Copy link
Member Author

yndajas commented Feb 9, 2023

Oh that's a really good point. I guess non-technical people will look at the site and not the README?

I'd guess so! Might be worth adding an issue to review/pick this up separately?

@yndajas yndajas merged commit b6c7ae8 into main Feb 9, 2023
@yndajas yndajas deleted the more-detailed-redirect-guidance branch February 9, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants