-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Burger menu #264
Merged
Merged
Burger menu #264
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
033fe64
Adds classes to display menu with transition on click, #249
8b9a943
Adds burger symbol, #249
7e7160f
Removes vh-100 and fixed classes, #249
a62e08c
Fixes nav and removes min height, #249
f57704b
Adds menu class so display changes with checkbox, #249
cb79046
Adds min height so nav always show dwyl, #249
276a544
Positions dwyl absolutely on mob, #249
d9b0e87
Increases padding to account for mobile navbar, #260
48c7aa8
Adds 'home' to nav on mobile, #249
4a3c62a
Amends padding for mob menu, #249
1101f4f
Replaces vh with rem
a84d2af
Replaces custom class with tachyons substitute, #265
03f39b2
Substitutes grey for gray, #266
c80801a
Refactors to remove overflow-hidden from custom class, #266
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transition feels a bit slow, could we make it a bit faster?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made it faster for you @SimonLab https://github.com/dwyl/learn-tachyons/pull/52/files#diff-910fef80905cec0740d8c9b257c89defR47 😉